Add ReviewReadService and extract shared validation helpers#64
Merged
Conversation
Introduces the analyzer review service: - DailyReviewView (review_date, review_text, created_at) and WeeklyReviewView (week_start, computed week_end, review_text, created_at). Plumbing fields like model and prompt_version are intentionally hidden from the analyzer surface. - GetReviewsRequest with required from_date and to_date_exclusive. - ReviewReadService trait and DefaultReviewReadService impl wrapping DailyReviewRepository::fetch_completed_in_range and the matching weekly method. Returned reviews are guaranteed completed and non-empty by the underlying queries. Extracts validate_limit / validate_optional_range / validate_range into a shared validation submodule so journal.rs and review.rs share the same input rules. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the analyzer review service:
Extracts validate_limit / validate_optional_range / validate_range into a shared validation submodule so journal.rs and review.rs share the same input rules.