Skip to content

Cache pyproject.toml parsing in workspace discovery - #19007

Closed
konstin wants to merge 2 commits into
mainfrom
konsti/simplified-workspace-caching
Closed

Cache pyproject.toml parsing in workspace discovery#19007
konstin wants to merge 2 commits into
mainfrom
konsti/simplified-workspace-caching

Conversation

@konstin

@konstin konstin commented Apr 15, 2026

Copy link
Copy Markdown
Member

No description provided.

@konstin
konstin force-pushed the konsti/simplified-workspace-caching branch from 94d4078 to c4d0c5d Compare April 15, 2026 11:43
@konstin konstin changed the title Simplified workspace caching Cache parsed pyproject.toml in workspace discovery Apr 20, 2026
@konstin
konstin force-pushed the konsti/simplified-workspace-caching branch 2 times, most recently from 72bb02b to 2886470 Compare April 20, 2026 18:59
@konstin konstin changed the title Cache parsed pyproject.toml in workspace discovery Cache pyproject.toml parsing in workspace discovery Apr 20, 2026
@konstin
konstin force-pushed the konsti/simplified-workspace-caching branch 2 times, most recently from ca9eef9 to 0eea6e7 Compare April 25, 2026 20:57
@konstin

konstin commented Apr 26, 2026

Copy link
Copy Markdown
Member Author

Unfortunately, glob walking is also slow:

image
samply record --iteration-count 10 --rate 10000 --reuse-threads ./uv-pyproject-toml-cache tree --offline --depth 1

@konstin
konstin force-pushed the konsti/simplified-workspace-caching branch from 0eea6e7 to e37bddf Compare April 26, 2026 12:09
@konstin
konstin force-pushed the konsti/simplified-workspace-caching branch from eb131e6 to c0e29cc Compare May 21, 2026 09:51
konstin added 2 commits June 5, 2026 11:24
This doesn't actually change workspace discovery (anymore), so we can error after discovery.
@konstin
konstin force-pushed the konsti/simplified-workspace-caching branch from c0e29cc to 55c5c40 Compare June 5, 2026 09:43
@konstin

konstin commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

Superseded by #18311, which has merged.

@konstin konstin closed this Jun 5, 2026
@konstin
konstin deleted the konsti/simplified-workspace-caching branch June 5, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant