Skip to content

Create pictures dir if non existent#5181

Merged
dhh merged 2 commits into
basecamp:devfrom
brunorwx:issue/5174
Apr 2, 2026
Merged

Create pictures dir if non existent#5181
dhh merged 2 commits into
basecamp:devfrom
brunorwx:issue/5174

Conversation

@brunorwx
Copy link
Copy Markdown
Contributor

@brunorwx brunorwx commented Apr 1, 2026

Create pictures dir if non existent.

Issue #5174

Copilot AI review requested due to automatic review settings April 1, 2026 22:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Don't need to guard against mkdir failing
@dhh dhh merged commit 08b3179 into basecamp:dev Apr 2, 2026
@brunorwx brunorwx deleted the issue/5174 branch April 2, 2026 10:33
@Kasui92
Copy link
Copy Markdown
Contributor

Kasui92 commented Apr 2, 2026

@dhh
This commit removed the mkdir -p that actually creates the folder.

@brunorwx brunorwx restored the issue/5174 branch April 2, 2026 13:21
@brunorwx
Copy link
Copy Markdown
Contributor Author

brunorwx commented Apr 2, 2026

I think you are right, I've created a PR where I just added the mkdir -p cmd.

#5189

EFrMG pushed a commit to EFrMG/omarchy that referenced this pull request Apr 4, 2026
* Create pictures dir if non existent

* Simplify

Don't need to guard against mkdir failing

---------

Co-authored-by: David Heinemeier Hansson <david@hey.com>
marxin pushed a commit to marxin/omarchy that referenced this pull request Apr 4, 2026
* Create pictures dir if non existent

* Simplify

Don't need to guard against mkdir failing

---------

Co-authored-by: David Heinemeier Hansson <david@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants