refactor(storefront): STRF-8607 Update all dev dependecies on stencil utils#128
Conversation
|
Autotagging @bigcommerce/storefront-team |
d7623b8 to
3d8ced2
Compare
832ee28 to
54a4ce5
Compare
8375078 to
686904e
Compare
| [ | ||
| '@babel/preset-env', | ||
| { | ||
| targets: '> 1%, last 2 versions, Firefox ESR', |
There was a problem hiding this comment.
Let’s make sure this matches the setting we have defined in cornerstone
There was a problem hiding this comment.
@junedkazi yes, we grabbed it from Cornerstone
https://github.com/bigcommerce/cornerstone/blob/master/webpack.common.js#L33
| "eventemitter3": "^4.0.4", | ||
| "whatwg-fetch": "^3.4.0" | ||
| }, | ||
| "browserslist": "> 0.25%, not dead", |
There was a problem hiding this comment.
We should make this consistent with Babel target and also make sure it aligns with cornerstone config
There was a problem hiding this comment.
We can even move it out to a separate .browserslistrc file so that this config is used by all the libraries which may need it (as it's recommended here: https://babeljs.io/docs/en/babel-preset-env#browserslist-integration )
| optimization: { | ||
| minimize: true, | ||
| }, | ||
| devtool: false, |
There was a problem hiding this comment.
Is there a reason why we are changing this to false ?
There was a problem hiding this comment.
devtool is used only in mode: 'development'. We are using 'production' build, so we don't need to specify it
9606836 to
3fdab62
Compare
| @@ -0,0 +1 @@ | |||
| last 1 version, >2% No newline at end of file | |||
There was a problem hiding this comment.
well I wonder if we need to define one here or should we just rely on what the theme has ?
There was a problem hiding this comment.
It will be used by babel, that is used in webpack and is in current repo(and other tools, that have possibility to use .browserslistrc https://github.com/browserslist/browserslist#browserslist-). We will need to sync all repos together, I've got a PR for cornerstone with more info bigcommerce/cornerstone#1836
| "eslint-plugin-import": "^2.22.0", | ||
| "jest": "^26.4.2", | ||
| "webpack": "^4.44.1", | ||
| "webpack-cli": "^3.3.12" |
There was a problem hiding this comment.
why do we need the cli package ?
There was a problem hiding this comment.
For running build from cli https://webpack.js.org/guides/installation/
| @@ -0,0 +1 @@ | |||
| last 1 version, >2% No newline at end of file | |||
There was a problem hiding this comment.
is there a reason why we are dropping firefox esr
There was a problem hiding this comment.
junedkazi
left a comment
There was a problem hiding this comment.
I wonder if we should drop the lock file as well here ? @MaxGenash @jairo-bc @mattolson thoughts ?
Yep, makes sense, since it's a dependency library |
junedkazi
left a comment
There was a problem hiding this comment.
LGTM 👍 . I was wondering if you want to drop the package lock in this PR itself or in a follow up PR ?
Just added to this one |
junedkazi
left a comment
There was a problem hiding this comment.
We should hold off on merging this one until we get a confirmation on .browserslistrc change from @bookernath and @bc-as
| @@ -0,0 +1 @@ | |||
| >2%, last 1 version, Firefox ESR No newline at end of file | |||
No description provided.