Skip to content

Give title to sub-schemas of oneOf for sum types#88

Merged
maksbotan merged 2 commits into
masterfrom
maksbotan/one-of-title
Nov 20, 2023
Merged

Give title to sub-schemas of oneOf for sum types#88
maksbotan merged 2 commits into
masterfrom
maksbotan/one-of-title

Conversation

@maksbotan

Copy link
Copy Markdown
Collaborator

No description provided.

@maksbotan
maksbotan force-pushed the maksbotan/one-of-title branch from 4a2c52b to ac63e99 Compare November 18, 2023 23:41
@maksbotan
maksbotan force-pushed the maksbotan/one-of-title branch from ac63e99 to a8c3312 Compare November 18, 2023 23:53
@maksbotan
maksbotan merged commit 65968b9 into master Nov 20, 2023
dhess added a commit to hackworthltd/primer that referenced this pull request Feb 6, 2024
The previous commit bumped the `openapi3` package to version `3.2.4`,
which contains this pull request:

biocad/openapi3#88

The title of that PR is simply, "Give title to sub-schemas of oneOf
for sum types", and that is what has happened here to our golden test
output. Unhelpfully, there's no justification for why this change was
made, but it looks harmless enough. (This will presumably require a
corresponding schema change on the client side, though.)

We also bump the PVP for `openapi3` to reflect the new minimum version
requirement.

Signed-off-by: Drew Hess <src@drewhess.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant