Run specs from solargraph-rails configured against current code in CI

[apiology]

Depends on iftheshoefritz/solargraph-rails#161

[apiology]

Hi @lekemula! I almost broke compatibility with solargraph-rspec in #890 :(. I'd like to set CI up here to ensure that solargraph-rspec specs run when configured against the solargraph code in the PR. There do seem to be some existing failures, though.

I know at least some of these are pending #877 - if you get a chance, though, could you take a look at the others and let me know whether the problem seems to be in solargraph or solargraph-rspec or just a spec adjustment to make?

[lekemula]

Hi @apiology, thanks for all the incredible work that you're doing, and particularly for adding this pipeline, which is obviously a much-needed one, seeing the recent regressions.

So I took a look into this here, and as you've guessed:

• Some of the failures are just small adjustments (see here and here)
• The others (regarding 3rd party rspec gems support) should probably get fixed by [breaking] Reimplement global conventions #877

But there is one failure that seems to be legit though: see this commit

  3) Solargraph::Rspec::Convention type inference infers type for
some_module
     Failure/Error: inferred_return_type = pin.probe(api_map).tag

     RuntimeError:
       You must supply parameters_type if you provide parameters
     # /Users/lekemula/Projects/solargraph/lib/solargraph/complex_type/unique_type.rb:64:in
`initialize'
     # /Users/lekemula/Projects/solargraph/lib/solargraph/complex_type/unique_type.rb:245:in
`new'
     # /Users/lekemula/Projects/solargraph/lib/solargraph/complex_type/unique_type.rb:245:in
`recreate'

That seems to be coming from #813 - any ideas what could be missing there?

Another interesting finding is that the fixes from solargraph 0.53.0, seem to be regressed in solargraph 0.53.3 - @castwide any ideas what could be causing that?

I should probably try to keep solargraph-rspec specs more up-to-date and running against the latest solargraph release, at least until we have this pipeline up and running 🚀

[apiology]

Thank you for your kind words!

Could you try bundle exec solargraph clear and see if it still happens? I've been breaking compatibility with the solargraph cached pins between PRs, so you may have some cached pins hanging around.

[lekemula]

Thank you for your kind words!

Could you try bundle exec solargraph clear and see if it still happens? I've been breaking compatibility with the solargraph cached pins between PRs, so you may have some cached pins hanging around.

It fixed 🥳 - thank you!

So I guess we just need to wait for #877.

[castwide]

So I guess we just need to wait for #877.

I want to fix support for global conventions very soon. It won't be in the release coming this month, unfortunately, but hopefully the release after that.

[apiology]

This is ready to go. I haven't gotten solargraph-rspec working yet, but I can do that in a follow-up PR once I have a chance to dig in on it.