fix: handle empty children in box_dots setitem#318
Open
santhreal wants to merge 1 commit into
Open
Conversation
box_dots paths that end with a trailing dot leave an empty children segment; children[0] then raised IndexError while creating the intermediate container. Use children[:1] so empty children create a Box and set the empty-string key, matching existing parent paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Box.setitem (box_dots) hits IndexError when trailing/empty dotted path children[0] with default_box. This PR fixes the regression with a focused test covering the case.