Skip to content

Russian language support#255

Merged
auvipy merged 5 commits into
celery:masterfrom
ildarworld:ru-locale
Nov 12, 2021
Merged

Russian language support#255
auvipy merged 5 commits into
celery:masterfrom
ildarworld:ru-locale

Conversation

@ildarworld

Copy link
Copy Markdown
Contributor

Russian locale file is added

@auvipy auvipy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will need another russ speaking person to double check. can you tag someone you know

@ildarworld

Copy link
Copy Markdown
Contributor Author

will need another russ speaking person to double check. can you tag someone you know

Guys, could you be so kind and help with double check the PR for Russian language support for django-celery-results?
@f213
@alexey-goloburdin

@neoromantique neoromantique left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Native Russian Speaker)

Comment thread locale/ru/LC_MESSAGES/django.po Outdated
Co-authored-by: Stepan Rakitin <stepanr@mailbox.org>
Comment thread locale/ru/LC_MESSAGES/django.po Outdated
Comment thread locale/ru/LC_MESSAGES/django.po Outdated
Comment thread locale/ru/LC_MESSAGES/django.po Outdated
ildarworld and others added 3 commits November 12, 2021 12:26
Co-authored-by: Stepan Rakitin <stepanr@mailbox.org>
Co-authored-by: Stepan Rakitin <stepanr@mailbox.org>
Co-authored-by: Stepan Rakitin <stepanr@mailbox.org>
@auvipy auvipy merged commit fe76387 into celery:master Nov 12, 2021

#: django_celery_results/models.py:68 django_celery_results/models.py:176
msgid "Created DateTime"
msgstr "ДатаВремя создания"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think «Дата и время» would be more russian then «ДатаВремя»

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with all proposed changes

Will apply them ASAP

msgid ""
"JSON meta information about the task, such as information on child tasks"
msgstr ""
"JSON мета информация о Задании, такая как информация о дочерних Заданиях"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be «метаинформация» instead of «мета информация»


#: django_celery_results/models.py:92
msgid "task results"
msgstr "результаты задания"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is verbose_name_plural — a name for multiple instances of a task result, so it would be better as «результаты заданий»

msgid ""
"JSON serialized list of task result tuples. use .group_result() to decode"
msgstr ""
"JSON сериалованный список таплов результата задания. Используйте .group_result() для декодирования"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google trends show that «кортеж» из more popular translation for Tuple then «тапл»

@auvipy

auvipy commented Nov 12, 2021

Copy link
Copy Markdown
Member

fixes are welcome

@f213 f213 mentioned this pull request Nov 13, 2021
@f213

f213 commented Nov 13, 2021

Copy link
Copy Markdown
Contributor

I created #256 with suggested fixes, could you guys please check it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants