Remove GITHUB_TOKEN env var support#674
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 6f1dfae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Andarist
approved these changes
Jun 29, 2026
| core.setFailed("Please add the GITHUB_TOKEN to the changesets action"); | ||
| return; | ||
| const githubToken = getRequiredInput("github-token"); | ||
| if (process.env.GITHUB_TOKEN && process.env.GITHUB_TOKEN !== githubToken) { |
Member
There was a problem hiding this comment.
If we have this "they have to match if both are specified" rule - shouldn't we kinda also enforce that in other subactions that use github-token?
Member
Author
There was a problem hiding this comment.
I think this is more for compat to push migration, so eventually in the next major we can remove this and we don't have to mind about GITHUB_TOKEN anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns with the behaviour with the other sub-actions, but with an error if the old pattern is still used.