Repository navigation
Line chart with tension of 0 renders incorrectly #2467
Description
As demonstrated at http://jsbin.com/wawowateru/2/edit?html,js,output a line chart with tension of 0 (to get straight lines) renders incorrectly. This worked correctly at 3166895 so a regression must have crept in.
For now, a workaround is to use a very small tension (e.g. 0.000001 - http://jsbin.com/zadiwohuxa/1/edit?html,js,output). I will try and have a look in to what is causing this myself, logging it here first though.
Activity
etimberg commentedon May 5, 2016
I'm kinda surprised by this given that https://github.com/chartjs/Chart.js/blob/master/src/elements/element.line.js hasn't been touched in months but that might be the problem. I think the tension got removed from the points
tomduncalf commentedon May 5, 2016
Hm yes, that would make sense – not sure what the best way to address this is without context
etimberg commentedon May 5, 2016
Either the tension here needs to come from the line view and not the point view
or
https://github.com/chartjs/Chart.js/blob/master/src/controllers/controller.line.js#L197-L208 needs to also set the tension
etimberg commentedon May 6, 2016
PR to fix this in #2473
tomduncalf commentedon May 6, 2016
Nice, thank you!
On 6 May 2016 at 12:22, Evert Timberg notifications@github.com wrote:
etimberg commentedon May 7, 2016
Released in version 2.1.1.