refactor: simplify packet sending loop using core::slice::chunks #2294
+2
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apps/src/sendto.rs
Outdated
|
|
||
| match socket.send_to(&buf[off..off + pkt_len], send_info.to) { | ||
| for chunk in buf.chunks(segment_size) { | ||
| match socket.send_to(&chunk, send_info.to) { |
Contributor
There was a problem hiding this comment.
Nice simplification. Please see CI failures due to compile warnings:
error: unused import: `std::cmp`
--> apps/src/sendto.rs:27:5
|
27 | use std::cmp;
LPardue
reviewed
Dec 18, 2025
| let pkt_len = cmp::min(left, segment_size); | ||
|
|
||
| match socket.send_to(&buf[off..off + pkt_len], send_info.to) { | ||
| for chunk in buf.chunks(segment_size) { |
Contributor
There was a problem hiding this comment.
According to rustdocs, Segment_size 0 will panic. We should probably have an earlier check for that. The lack of check in the old code would be a problem too but would manifest differently
c1194e9 to
ee0e418
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.