You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The code looks clean. Let me review the overall PR:
Implementation (_workers.py): The cf property is clean and follows the existing pattern (same as body using _jsnull_to_none). The type annotation JsProxy | None is correct. The docstring is clear and includes a link to the relevant documentation.
Tests (test_sdk.py): The test covers both cases — a newly constructed Request without cf (returns None) and an incoming request through workerd where cf is present. The JsProxy import was already present in the file.
Placement: The property is placed between body_used and cache, which is reasonable alphabetical ordering.
There are no logic bugs, security issues, backward compatibility concerns, or other actionable problems. The change is a straightforward addition of a missing accessor property that follows existing patterns in the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This accessor is missing, so users would instead need to use
request.js_object.cfmanually to access it, which isn't ideal.