You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I can see the diff clearly. The PR changes the build_command in packages/runtime-sdk/pyproject.toml to add uv lock and git add uv.lock steps, mirroring what's done in the CLI package. Let me compare the two build_command blocks more closely.
The CLI package (packages/cli/pyproject.toml:108-114) has:
The only difference is the missing python -m pip install -e .[build] line. The CLI package has this because it has a [project.optional-dependencies] build = ["uv ~= 0.5.23"] — the runtime-sdk package doesn't have such a dependency group, so omitting it is correct.
The $PACKAGE_NAME environment variable is a built-in from python-semantic-release that resolves to the package name. The uv lock command will update the lockfile for the specific package being released, and git add uv.lock stages it so it gets included in the release commit.
This is a straightforward and correct fix. The change is minimal, matches the pattern established by the CLI package (with the appropriate omission), and addresses the stated issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in our release configuration that the automated ci is not updating the
uv.lockfile.I copied the build_command from the workers-py package:
workers-py/packages/cli/pyproject.toml
Lines 108 to 113 in 7c5179f