Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix merge
  • Loading branch information
jcvrabo committed Mar 18, 2025
commit e9b36da9315c4f2d3977bbb1843303a67885f9f3
2 changes: 1 addition & 1 deletion actor/v7action/process_readiness_health_check.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package v7action
import (
"sort"

"code.cloudfoundry.org/cli/api/cloudcontroller/ccv3/constant"
"code.cloudfoundry.org/cli/v8/api/cloudcontroller/ccv3/constant"
)

type ProcessReadinessHealthCheck struct {
Expand Down
12 changes: 6 additions & 6 deletions actor/v7action/process_readiness_health_check_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@ package v7action_test
import (
"errors"

"code.cloudfoundry.org/cli/actor/actionerror"
. "code.cloudfoundry.org/cli/actor/v7action"
"code.cloudfoundry.org/cli/actor/v7action/v7actionfakes"
"code.cloudfoundry.org/cli/api/cloudcontroller/ccv3"
"code.cloudfoundry.org/cli/api/cloudcontroller/ccv3/constant"
"code.cloudfoundry.org/cli/resources"
"code.cloudfoundry.org/cli/v8/actor/actionerror"
. "code.cloudfoundry.org/cli/v8/actor/v7action"
"code.cloudfoundry.org/cli/v8/actor/v7action/v7actionfakes"
"code.cloudfoundry.org/cli/v8/api/cloudcontroller/ccv3"
"code.cloudfoundry.org/cli/v8/api/cloudcontroller/ccv3/constant"
"code.cloudfoundry.org/cli/v8/resources"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
)
Expand Down
6 changes: 3 additions & 3 deletions command/v7/get_readiness_health_check_command.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ import (
"fmt"
"strconv"

"code.cloudfoundry.org/cli/actor/v7action"
"code.cloudfoundry.org/cli/command/flag"
"code.cloudfoundry.org/cli/util/ui"
"code.cloudfoundry.org/cli/v8/actor/v7action"
"code.cloudfoundry.org/cli/v8/command/flag"
"code.cloudfoundry.org/cli/v8/util/ui"
)

type GetReadinessHealthCheckCommand struct {
Expand Down
18 changes: 9 additions & 9 deletions command/v7/get_readiness_health_check_command_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ package v7_test
import (
"errors"

"code.cloudfoundry.org/cli/actor/actionerror"
"code.cloudfoundry.org/cli/actor/v7action"
"code.cloudfoundry.org/cli/api/cloudcontroller/ccv3/constant"
"code.cloudfoundry.org/cli/command/commandfakes"
"code.cloudfoundry.org/cli/command/flag"
. "code.cloudfoundry.org/cli/command/v7"
"code.cloudfoundry.org/cli/command/v7/v7fakes"
"code.cloudfoundry.org/cli/util/configv3"
"code.cloudfoundry.org/cli/util/ui"
"code.cloudfoundry.org/cli/v8/actor/actionerror"
"code.cloudfoundry.org/cli/v8/actor/v7action"
"code.cloudfoundry.org/cli/v8/api/cloudcontroller/ccv3/constant"
"code.cloudfoundry.org/cli/v8/command/commandfakes"
"code.cloudfoundry.org/cli/v8/command/flag"
. "code.cloudfoundry.org/cli/v8/command/v7"
"code.cloudfoundry.org/cli/v8/command/v7/v7fakes"
"code.cloudfoundry.org/cli/v8/util/configv3"
"code.cloudfoundry.org/cli/v8/util/ui"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
. "github.com/onsi/gomega/gbytes"
Expand Down
2 changes: 1 addition & 1 deletion command/v7/map_route_command_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"errors"
"strconv"

"code.cloudfoundry.org/cli/api/cloudcontroller/ccversion"
"code.cloudfoundry.org/cli/v8/api/cloudcontroller/ccversion"

"code.cloudfoundry.org/cli/v8/actor/actionerror"
"code.cloudfoundry.org/cli/v8/actor/v7action"
Expand Down
10 changes: 5 additions & 5 deletions command/v7/update_route_command.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ package v7
import (
"fmt"

"code.cloudfoundry.org/cli/actor/actionerror"
"code.cloudfoundry.org/cli/api/cloudcontroller/ccversion"
"code.cloudfoundry.org/cli/command"
"code.cloudfoundry.org/cli/command/flag"
"code.cloudfoundry.org/cli/resources"
"code.cloudfoundry.org/cli/v8/actor/actionerror"
"code.cloudfoundry.org/cli/v8/api/cloudcontroller/ccversion"
"code.cloudfoundry.org/cli/v8/command"
"code.cloudfoundry.org/cli/v8/command/flag"
"code.cloudfoundry.org/cli/v8/resources"
)

type UpdateRouteCommand struct {
Expand Down
24 changes: 12 additions & 12 deletions command/v7/update_route_command_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,17 @@ import (
"fmt"
"strconv"

"code.cloudfoundry.org/cli/api/cloudcontroller/ccversion"

"code.cloudfoundry.org/cli/actor/actionerror"
"code.cloudfoundry.org/cli/actor/v7action"
"code.cloudfoundry.org/cli/command/commandfakes"
"code.cloudfoundry.org/cli/command/flag"
. "code.cloudfoundry.org/cli/command/v7"
"code.cloudfoundry.org/cli/command/v7/v7fakes"
"code.cloudfoundry.org/cli/resources"
"code.cloudfoundry.org/cli/util/configv3"
"code.cloudfoundry.org/cli/util/ui"
"code.cloudfoundry.org/cli/v8/api/cloudcontroller/ccversion"

"code.cloudfoundry.org/cli/v8/actor/actionerror"
"code.cloudfoundry.org/cli/v8/actor/v7action"
"code.cloudfoundry.org/cli/v8/command/commandfakes"
"code.cloudfoundry.org/cli/v8/command/flag"
. "code.cloudfoundry.org/cli/v8/command/v7"
"code.cloudfoundry.org/cli/v8/command/v7/v7fakes"
"code.cloudfoundry.org/cli/v8/resources"
"code.cloudfoundry.org/cli/v8/util/configv3"
"code.cloudfoundry.org/cli/v8/util/ui"

. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
Expand Down Expand Up @@ -259,7 +259,7 @@ var _ = Describe("update-route Command", func() {
Expect(actualRouteGUID).To(Equal("route-guid"))
Expect(actualOptions).To(Equal(options))

//Second update route call to remove the option
// Second update route call to remove the option
actualRouteGUID, actualOptions = fakeActor.UpdateRouteArgsForCall(1)
Expect(actualRouteGUID).To(Equal("route-guid"))
options["loadbalancing"] = nil
Expand Down
2 changes: 0 additions & 2 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ require (
github.com/mattn/go-isatty v0.0.20 // indirect
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
github.com/modern-go/reflect2 v1.0.2 // indirect
github.com/nxadm/tail v1.4.8 // indirect
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
github.com/opencontainers/go-digest v1.0.0 // indirect
github.com/openzipkin/zipkin-go v0.4.3 // indirect
Expand All @@ -90,7 +89,6 @@ require (
google.golang.org/grpc v1.63.2 // indirect
google.golang.org/protobuf v1.36.1 // indirect
gopkg.in/inf.v0 v0.9.1 // indirect
gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
k8s.io/klog/v2 v2.130.1 // indirect
k8s.io/utils v0.0.0-20241104100929-3ea5e8cea738 // indirect
Expand Down
2 changes: 0 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
code.cloudfoundry.org/bytefmt v0.30.0 h1:q3Vk60UNnF9FJRdlDhiymI6t+FKDiNDiSL6lYBlvGsU=
code.cloudfoundry.org/bytefmt v0.30.0/go.mod h1:q/RP0yKhJ3dpwSyQyTEv+GSitSD3m+0j/qJymOA9h/A=
code.cloudfoundry.org/cfnetworking-cli-api v0.0.0-20190103195135-4b04f26287a6 h1:Yc9r1p21kEpni9WlG4mwOZw87TB2QlyS9sAEebZ3+ak=
code.cloudfoundry.org/cfnetworking-cli-api v0.0.0-20190103195135-4b04f26287a6/go.mod h1:u5FovqC5GGAEbFPz+IdjycDA+gIjhUwqxnu0vbHwVeM=
code.cloudfoundry.org/cli-plugin-repo v0.0.0-20200304195157-af98c4be9b85 h1:jaHWw9opYjKPrDT19uydBBWSxl+g5F4Hv030fqMsalo=
code.cloudfoundry.org/cli-plugin-repo v0.0.0-20200304195157-af98c4be9b85/go.mod h1:R1EiyOAr7lW0l/YkZNqItUNZ01Q/dYUfbTn4X4Z+82M=
code.cloudfoundry.org/cli/integration/assets/hydrabroker v0.0.0-20201002233634-81722a1144e4 h1:O+j8afQWaDuxzKGcculsjgHGK+biBTn6iMjgFpBf54c=
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package isolated

import (
. "code.cloudfoundry.org/cli/cf/util/testhelpers/matchers"
"code.cloudfoundry.org/cli/integration/helpers"
. "code.cloudfoundry.org/cli/v8/cf/util/testhelpers/matchers"
"code.cloudfoundry.org/cli/v8/integration/helpers"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
. "github.com/onsi/gomega/gbytes"
Expand Down
19 changes: 2 additions & 17 deletions integration/v7/isolated/restage_command_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,22 +142,6 @@ var _ = Describe("restage command", func() {
})

When("strategy rolling is given", func() {
It("fails and displays the deployment failure message", func() {
userName, _ := helpers.GetCredentials()
session := helpers.CustomCF(helpers.CFEnv{
EnvVars: map[string]string{"CF_STARTUP_TIMEOUT": "0.1"},
}, "restage", appName, "--strategy", "rolling")
Consistently(session.Err).ShouldNot(Say(`This action will cause app downtime\.`))
Eventually(session).Should(Say(`Restaging app %s in org %s / space %s as %s\.\.\.`, appName, orgName, spaceName, userName))
Eventually(session).Should(Say(`Creating deployment for app %s\.\.\.`, appName))
Eventually(session).Should(Say(`Waiting for app to deploy\.\.\.`))
Eventually(session.Err).Should(Say(`Cannot cancel a deployment with status: FINALIZED and reason: DEPLOYED`))
Eventually(session).Should(Say("FAILED"))
Eventually(session).Should(Exit(1))
})
})

When("strategy rolling is given with max-in-flight", func() {
It("fails and displays the deployment failure message", func() {
userName, _ := helpers.GetCredentials()
session := helpers.CustomCF(helpers.CFEnv{
Expand All @@ -167,7 +151,8 @@ var _ = Describe("restage command", func() {
Eventually(session).Should(Say(`Restaging app %s in org %s / space %s as %s\.\.\.`, appName, orgName, spaceName, userName))
Eventually(session).Should(Say(`Creating deployment for app %s\.\.\.`, appName))
Eventually(session).Should(Say(`Waiting for app to deploy\.\.\.`))
Eventually(session.Err).Should(Say(`Cannot cancel a deployment with status: FINALIZED and reason: DEPLOYED`))
Eventually(session.Err).Should(Say(`Start app timeout`))
Eventually(session.Err).Should(Say(`TIP: Application must be listening on the right port\. Instead of hard coding the port, use the \$PORT environment variable\.`))
Eventually(session).Should(Say("FAILED"))
Eventually(session).Should(Exit(1))
})
Expand Down
4 changes: 2 additions & 2 deletions integration/v7/isolated/update_route_command_test.go
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package isolated

import (
. "code.cloudfoundry.org/cli/cf/util/testhelpers/matchers"
"code.cloudfoundry.org/cli/integration/helpers"
. "code.cloudfoundry.org/cli/v8/cf/util/testhelpers/matchers"
"code.cloudfoundry.org/cli/v8/integration/helpers"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
. "github.com/onsi/gomega/gbytes"
Expand Down
Loading