Skip to content

[main] Multiple commands changed to allow canary steps #3400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Samze merged 21 commits into from
Mar 26, 2025
Merged

[main] Multiple commands changed to allow canary steps #3400

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
1828e54
Fix error message for push command
joaopapereira Feb 5, 2025
4a99027
Display current step in the canary deployment
joaopapereira Feb 5, 2025
1e2ab6c
Add --instance-steps to the restart command
joaopapereira Feb 12, 2025
ecdc90b
Add flag --instance-steps to restage command
joaopapereira Feb 18, 2025
e7931ef
Add --instance-steps to rollback
joaopapereira Feb 19, 2025
42cb1fe
Add --instance-steps to copy-source command
joaopapereira Feb 19, 2025
15e2367
Fix rollback that was not setting the correct values on the deployment
joaopapereira Feb 20, 2025
12e4524
Add min capi version check on instance steps commands
joaopapereira Feb 20, 2025
701812c
Merge branch 'main' into main-restart-canary-steps
Samze Mar 12, 2025
fa8670e
Fix pointer reference
Samze Mar 13, 2025
e47b6a6
Add version to copy-source canary step test
Samze Mar 13, 2025
e9c4744
Update canary step version requirement
Samze Mar 13, 2025
1894f8e
Fix continue deployment test
Samze Mar 13, 2025
1272d35
Fix CAPI versions in tests
Samze Mar 13, 2025
af8c745
Fixes for canary integration tests
Samze Mar 13, 2025
da9fa8a
Merge branch 'main' into main-restart-canary-steps
Samze Mar 18, 2025
d215054
Merge branch 'main' into main-restart-canary-steps
Samze Mar 19, 2025
376ef4c
Merge branch 'main' into main-restart-canary-steps
Samze Mar 20, 2025
9c1a411
Fix flakey canary test
Samze Mar 20, 2025
35bc4d7
Add missing continue to copy-source canary test
Samze Mar 20, 2025
23647ce
Merge branch 'main' into main-restart-canary-steps
Samze Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix pointer reference
  • Loading branch information
@Samze
Samze committed Mar 13, 2025
commit fa8670eade4f2e65155ecbecf7d939306a531615
2 changes: 1 addition & 1 deletion command/v7/shared/app_stager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ func (stager *Stager) StartApp(app resources.Application, space configv3.Space,
}

if opts.Strategy == constant.DeploymentStrategyCanary && len(opts.CanarySteps) > 0 {
dep.Options = resources.DeploymentOpts{CanaryDeploymentOptions: resources.CanaryDeploymentOptions{Steps: opts.CanarySteps}}
dep.Options = resources.DeploymentOpts{CanaryDeploymentOptions: &resources.CanaryDeploymentOptions{Steps: opts.CanarySteps}}
}
switch opts.AppAction {
case constant.ApplicationRollingBack:
Expand Down
Loading