Skip to content

Conversation

@marckhouzam
Copy link
Contributor

@marckhouzam marckhouzam commented Sep 16, 2025

Description of the Change

I noticed this typo in the json tag. Searching the code with my IDE, I don't see any use of the field OAuthClient except in a test. Furthermore, I believe this field (and its parents) are not marshalled but only unmarshalled. I am not 100% sure however. But if that is the case, it is safe to make this change since it won't break anything.

Note also that from limited testing, I can see that when requesting the links from a fondation, the app_ssh link section is served using oauth_client as shown below

    "app_ssh": {
      "href": "ssh.sys.tas.3e03f83b.shepherd.tanzu.broadcom.net:2222",
      "meta": {
        "host_key_fingerprint": "31:9e:8e:e5:77:80:f3:f5:fc:c1:32:d7:23:cc:ce:a1",
        "oauth_client": "ssh-proxy"
      }
    },

This means that without this PR, if the field OAuthClient were to be used in the future, it would not work, as it would never be filled when unmarshaling.

Why Is This PR Valuable?

This PR is just about avoiding someone wasting time in the future trying to make this field work and hitting this bug.

Applicable Issues

N/A

How Urgent Is The Change?

Not urgent.

Other Relevant Parties

No one, yet.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 16, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: marckhouzam / name: Marc Khouzam (022e078)

Signed-off-by: Marc Khouzam <[email protected]>
@Samze Samze merged commit 4b92b73 into cloudfoundry:v8 Sep 16, 2025
20 of 21 checks passed
@marckhouzam marckhouzam deleted the marck/fixJson branch September 16, 2025 17:51
marckhouzam added a commit to marckhouzam/cf-cli that referenced this pull request Oct 27, 2025
gururajsh pushed a commit that referenced this pull request Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants