Skip to content

Bump tool TCE-908 - #32

Closed
stefanvacareanu7 wants to merge 4 commits into
masterfrom
bump_tool
Closed

Bump tool TCE-908#32
stefanvacareanu7 wants to merge 4 commits into
masterfrom
bump_tool

Conversation

@stefanvacareanu7

Copy link
Copy Markdown

No description provided.

Comment thread Dockerfile
@@ -1,10 +1,10 @@
FROM crystallang/crystal:1.10.1-alpine as builder
FROM crystallang/crystal:1.12-alpine as builder

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FROM crystallang/crystal:1.12-alpine as builder
FROM crystallang/crystal:1.14-alpine as builder

This should fix the error in https://app.circleci.com/pipelines/github/codacy/codacy-ameba/142/workflows/fd56e448-f53d-4144-95a1-2365b631c925/jobs/511

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Sija
Let me apologize for the huge delay in this reply and thank you for the tips and help with this upgrade.
I'm currently working on bumping Ameba to the latest version in the PR #33
All packages and versions will be there.
Thanks again. I appreciate your contribution a lot.
David Marinho

Comment thread Dockerfile
FROM crystallang/crystal:1.12-alpine as builder
WORKDIR /tmp/build
COPY . /tmp/build
RUN shards build --production

@Sija Sija Oct 14, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--release flag builds an optimized binary + -Dpreview_mt enables multi-threading (MT).

Suggested change
RUN shards build --production
RUN shards build --production --release -Dpreview_mt

Enabled: true
MinNameLength: 3
AllowNamesEndingInNumbers: true
AllowedNames: [_, e, i, j, k, v, x, y, ex, io, ws, op, tx, id, ip, k1, k2, v1, v2]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed in v1.6.3.

Suggested change
AllowedNames: [_, e, i, j, k, v, x, y, ex, io, ws, op, tx, id, ip, k1, k2, v1, v2]
AllowedNames: [e, i, j, k, v, x, y, ex, io, ws, op, tx, id, ip, k1, k2, v1, v2]

Comment thread shard.yml
- Vitalii Elenhaupt <velenhaupt@gmail.com>

crystal: 1.8.2
crystal: 1.12

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
crystal: 1.12
crystal: 1.14

Comment thread shard.yml
ameba:
github: crystal-ameba/ameba
version: 1.5.0
version: 1.6.1

@Sija Sija Oct 14, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 1.6.1
version: 1.6.4

Comment thread shard.lock
ameba:
git: https://github.com/crystal-ameba/ameba.git
version: 1.5.0
version: 1.6.1

@Sija Sija Oct 14, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ameba v1.6.4 is the latest release as of now (1.6.x were just a bugfix releases).

Suggested change
version: 1.6.1
version: 1.6.4

Comment thread docs/patterns.json
{
"name": "ameba",
"version": "1.5.0",
"version": "1.6.1",

@Sija Sija Oct 14, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "1.6.1",
"version": "1.6.4",

Comment thread .circleci/config.yml
unit_test:
docker: # run the steps with Docker
- image: crystallang/crystal:1.8.2
- image: crystallang/crystal:1.12

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- image: crystallang/crystal:1.12
- image: crystallang/crystal:1.14

Comment thread .idea/workspace.xml

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though this file was removed in 381627f it was added again in this commit.
I'd suggest adding .idea/ to the .gitignore.


```
Lint/SpecFilename:
Enabled: true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in v1.6.2.

Suggested change
Enabled: true
Enabled: true
IgnoredDirs: [spec/support spec/fixtures spec/data]
IgnoredFilenames: [spec_helper]

@Sija

Sija commented Oct 15, 2024

Copy link
Copy Markdown

ping @stefanvacareanu7

@Sija

Sija commented Oct 29, 2024

Copy link
Copy Markdown

@codacy is anyone still maintaining this?

@DMarinhoCodacy

Copy link
Copy Markdown

working on PR #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants