ci: Update runner to ubuntu-24.04#5
Closed
xeho91 wants to merge 9 commits into
Closed
Conversation
xeho91
commented
Jul 10, 2025
| ) | ||
| if (existingComment) return | ||
| } | ||
| github.issues.createComment({ owner, repo, issue_number, body }); No newline at end of file |
karwer
approved these changes
Jul 10, 2025
xeho91
commented
Jul 10, 2025
| }); | ||
| }; | ||
| fileReader.onloadend = () => { | ||
| void formikProps.setFieldValue("previewImage", { |
Contributor
Author
There was a problem hiding this comment.
There was a floating promise and ESLint was preventing from build. And then, the format was an issue.
| ); | ||
|
|
||
| setFieldValue("uploadedImageUrl", data.imageUrl); | ||
| await setFieldValue("uploadedImageUrl", data.imageUrl); |
Contributor
Author
There was a problem hiding this comment.
ESLint complained about a floating promise. Prevented from building the app.
| "format:locales": "eslint --fix -c 'src/footer-templates-app/config/locales/.eslintrc.js' --ext .json --format 'node_modules/eslint-plugin-i18n-json/formatter.js' 'src/footer-templates-app/config/locales/**/*.json'", | ||
| "tsc": "tsc", | ||
| "test": "react-scripts test --env=jest-environment-jsdom-fourteen", | ||
| "test": "react-scripts test --env=jsdom", |
Contributor
Author
There was a problem hiding this comment.
Security advisory forced me to upgrade the package, then the script.
Comment on lines
+47
to
+49
| type ActionsFromCreators<T extends ActionCreatorsMapObject> = ObjectValues<{ | ||
| [Key in keyof T]: ReturnType<T[Key]>; | ||
| }>; |
Contributor
Author
There was a problem hiding this comment.
Format issue blocking build
| "format:locales": "eslint --fix -c 'src/footer-templates-app/config/locales/.eslintrc.js' --ext .json --format 'node_modules/eslint-plugin-i18n-json/formatter.js' 'src/footer-templates-app/config/locales/**/*.json'", | ||
| "tsc": "tsc", | ||
| "test": "react-scripts test --env=jest-environment-jsdom-fourteen", | ||
| "test": "react-scripts test --env=jsdom --watchAll=false", |
Contributor
Author
There was a problem hiding this comment.
Temporary workaround to prevent Jest from running in interactive mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.