Include author name in thanks message and replace Toast with Snackbar - #6840
Include author name in thanks message and replace Toast with Snackbar#6840Kota-Jagadeesh wants to merge 17 commits into
Conversation
|
@neeldoshii updated the changes to keep the diff minimal by using context and existing ViewUtil methods. |
|
@neeldoshii Made the required changes, and tsted them, the changes worked well |
|
@neeldoshii, did you get time to review the changes above? LMK if any changes are needed 🙂 |
|
✅ Generated APK variants! |
chrisdebian
left a comment
There was a problem hiding this comment.
The message content change (adding the author's name, with a sensible fallback string when there's no author) looks correct and is well tested.
One thing worth flagging: the description says this replaces Toast with Snackbar specifically to avoid truncation on longer filename+username combinations, but the diff still calls `ViewUtil.showShortToast()` everywhere, which wraps `Toast.makeText(...)` (checked directly) — no Snackbar anywhere in this PR, and the tests still assert against `ShadowToast`. So as written, this makes the truncation risk the PR describes worse rather than better, since the message is now longer (filename + author) but still going through the same 2-line-limited Toast.
Was the Snackbar swap perhaps meant for a follow-up PR, or did it get dropped somewhere along the way? Happy to take another look once that's clarified.
Description (required)
Follow-up to #5211
updated the thanks toast message shown during review to include the author’s name along with the filename. Previously, the toast was only displayed the filename, which did not clearly indicate who was being thanked.
and as per the discussions in the PR #5211, replaced the toast with snackbar to properly handle longer filenames and usernames, since toast is limited to two lines on newer versions and truncates text
What changes did you make and why?
ReviewControllerto include author name (firstRevision.user()) in all thanks-related messages.filenameandauthor name)Tests performed (required)
Tested ProdDebug on Redmi Note 13 Pro API level 36.
Screenshots (for UI changes only)
Snackbar now displays:

"Sending thanks for "filename" to "author"