Skip to content
This repository was archived by the owner on Sep 29, 2025. It is now read-only.

Feat: initial appcontainer setup#38

Merged
thekaveman merged 8 commits into
mainfrom
feat/appcontainer
Dec 10, 2024
Merged

Feat: initial appcontainer setup#38
thekaveman merged 8 commits into
mainfrom
feat/appcontainer

Conversation

@thekaveman

@thekaveman thekaveman commented Dec 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #10

Review this PR

  1. Checkout the branch locally (not in devcontainer)
  2. Make sure there are no other pending changes
  3. Add a sample git tag e.g. git tag -a 2024.12.1
  4. Build the app container docker compose build app
  5. Run the app container, confirm the version matches the sample tag docker compose run --entrypoint /bin/bash app then inside python manage.py --version
  6. Rebuild and reload the devcontainer, confirm it still works

@thekaveman thekaveman requested a review from a team as a code owner December 9, 2024 22:26
@thekaveman thekaveman marked this pull request as draft December 9, 2024 22:27
@thekaveman thekaveman self-assigned this Dec 9, 2024
@thekaveman thekaveman marked this pull request as ready for review December 9, 2024 23:06
@thekaveman thekaveman added this to the Initial project setup milestone Dec 9, 2024
@thekaveman thekaveman marked this pull request as draft December 10, 2024 16:16
@thekaveman thekaveman marked this pull request as ready for review December 10, 2024 16:25
@thekaveman

thekaveman commented Dec 10, 2024

Copy link
Copy Markdown
Member Author

@lalver1 let's merge your #41 first, since there will be some conflicts I think.

@thekaveman thekaveman marked this pull request as draft December 10, 2024 16:31
@thekaveman
feat(appcontainer): basic nginx configuration
1e2da55 
assuming a gunicorn app server available on a unix socket
@thekaveman
feat(appcontainer): gunicorn dependency and config
75d4d1e 
matches the nginx config to bind to the same unix socket
@thekaveman
feat(appcontainer): Docker image and Compose service
1d96993 
multi-stage image:

1. builds the local pems Python package
2. installs the pre-built pems Python package and other setup
@thekaveman
refactor(devcontainer): build on the appcontainer
a25e17f
@thekaveman
chore(pyproject): toml formatting
21ba628
@thekaveman
feat(pyproject): dynamic version via setuptools_scm
bde7176
@thekaveman
feat(django): let manage.py print the installed app version
66b6176
@thekaveman
chore(devcontainer): remap localhost directory
89e5a3b 
into the /caltrans/app directory setup for the appcontainer
@github-actions

github-actions Bot commented Dec 10, 2024

Copy link
Copy Markdown

Coverage report

This PR does not seem to contain any modification to coverable code.

@thekaveman thekaveman marked this pull request as ready for review December 10, 2024 20:06
@thekaveman thekaveman enabled auto-merge December 10, 2024 20:09
lalver1
lalver1 approved these changes Dec 10, 2024
View reviewed changes

@lalver1 lalver1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I went through the reviewing steps and there were no problems 👍

@thekaveman thekaveman merged commit c556975 into main Dec 10, 2024
@thekaveman thekaveman deleted the feat/appcontainer branch December 10, 2024 20:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@lalver1 lalver1 lalver1 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@thekaveman thekaveman

Labels

None yet

Projects

None yet

Milestone

Initial project setup

Development

Successfully merging this pull request may close these issues.

Initial app container setup

2 participants

@thekaveman @lalver1