Skip to content

fix: JSON schema issue with gemini tool calls#3851

Merged
sestinj merged 4 commits into
continuedev:mainfrom
monotykamary:fix/gemini-tool-calling-mcp
Feb 1, 2025
Merged

fix: JSON schema issue with gemini tool calls#3851
sestinj merged 4 commits into
continuedev:mainfrom
monotykamary:fix/gemini-tool-calling-mcp

Conversation

@monotykamary

Copy link
Copy Markdown
Contributor

Description

Fixes tool calling error that happens when using Gemini. Not actually sure if it's because of MCP servers, but at least now it works.

Checklist

  • Fixed and added JSON schema cleaning for processing tools with Gemini

Screenshots

image

Testing instructions

Select any Gemini model and enable tools. Prompt it in such a way that it will invoke the tool and see the results.

@netlify

netlify Bot commented Jan 26, 2025

Copy link
Copy Markdown

Deploy Preview for continuedev ready!

Name Link
🔨 Latest commit 7ce1943
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/679d5c7ae092970008afa19b
😎 Deploy Preview https://deploy-preview-3851--continuedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sestinj sestinj requested a review from RomneyDa January 27, 2025 21:31
Comment thread core/llm/llms/Gemini.ts Outdated
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:24 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:25 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:27 — with GitHub Actions Inactive
@RomneyDa

Copy link
Copy Markdown
Contributor

Note, have pulled branch and tested, works great.
Will merge today,

@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:28 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@sestinj sestinj merged commit 7220b49 into continuedev:main Feb 1, 2025
@sestinj

sestinj commented May 15, 2025

Copy link
Copy Markdown
Contributor

Hi @monotykamary, yesterday we shared some updates with our contributors about how we're aiming to improve the contribution process. Part of this included the addition of a Contributor License Agreement (CLA) to protect both contributors and the project. We're reaching out to ask that previous contributors sign it.

Could you please take a moment to sign, or if you have any questions send me a message? (either here or nate@continue.dev would work)

To do so, you just need to post a comment below with the following text:

I have read the CLA Document and I hereby sign the CLA

❤️ Thank you for the work you've done on Continue, and let me know if you have any suggestions on how we can make the project even better!

@github-actions

github-actions Bot commented May 15, 2025

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@monotykamary

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants