Skip to content

chore(clippy): allow API breaking clippy lints#305

Merged
m4tx merged 3 commits into
masterfrom
clippy-breaking-api
Apr 29, 2025
Merged

chore(clippy): allow API breaking clippy lints#305
m4tx merged 3 commits into
masterfrom
clippy-breaking-api

Conversation

@m4tx

@m4tx m4tx commented Apr 29, 2025

Copy link
Copy Markdown
Member

No description provided.

@m4tx m4tx requested a review from seqre April 29, 2025 16:41
@github-actions github-actions Bot added C-cli Crate: cot-cli (issues and Pull Requests related to Cot CLI) C-macros Crate: cot-macros C-codegen Crate: cot-codegen labels Apr 29, 2025
@m4tx m4tx force-pushed the clippy-breaking-api branch from 7fd43ae to 7bfb3cc Compare April 29, 2025 16:51
@codecov

codecov Bot commented Apr 29, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cot-cli/src/migration_generator.rs 94.73% 1 Missing ⚠️
Flag Coverage Δ
rust 84.57% <96.15%> (+1.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cot-cli/src/handlers.rs 95.49% <ø> (ø)
cot-codegen/src/model.rs 92.42% <100.00%> (ø)
cot-macros/src/dbtest.rs 92.85% <100.00%> (ø)
cot-macros/src/model.rs 93.75% <100.00%> (ø)
cot-cli/src/migration_generator.rs 88.76% <94.73%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread clippy.toml
@@ -1 +1,2 @@
doc-valid-idents = ["PostgreSQL", "MySQL", "SQLite", "JavaScript", "OpenAPI"]
avoid-breaking-exported-api = false

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this lint disabled?

@m4tx m4tx Apr 29, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting false here enables more lints, not disables them (as per the PR's title).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, I misread the clippy docs, disregard then, everything's fine!

@m4tx m4tx enabled auto-merge (squash) April 29, 2025 21:28
@m4tx m4tx merged commit 8696aaa into master Apr 29, 2025
@m4tx m4tx deleted the clippy-breaking-api branch April 29, 2025 21:33
@cotbot cotbot Bot mentioned this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cli Crate: cot-cli (issues and Pull Requests related to Cot CLI) C-codegen Crate: cot-codegen C-macros Crate: cot-macros

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants