Skip to content

feat: support more chrono datatypes in the framework#332

Merged
seqre merged 11 commits into
masterfrom
chrono-support
Jun 4, 2025
Merged

feat: support more chrono datatypes in the framework#332
seqre merged 11 commits into
masterfrom
chrono-support

Conversation

@seqre

@seqre seqre commented May 16, 2025

Copy link
Copy Markdown
Member

No description provided.

@seqre seqre self-assigned this May 16, 2025
@github-actions github-actions Bot added the C-lib Crate: cot (main library crate) label May 16, 2025
@seqre seqre marked this pull request as draft May 18, 2025 10:47
@seqre seqre requested a review from m4tx June 1, 2025 15:03
@seqre seqre marked this pull request as ready for review June 1, 2025 15:03
@codecov

codecov Bot commented Jun 2, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 90.00000% with 24 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cot/src/db/fields/chrono_wrapper.rs 88.78% 24 Missing ⚠️
Flag Coverage Δ
rust 88.21% <90.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cot/src/db/fields.rs 81.63% <100.00%> (+3.94%) ⬆️
cot/src/db/fields/chrono_wrapper.rs 88.78% <88.78%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@m4tx m4tx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please fix the minor issues I've mentioned in the comments.

Comment thread Cargo.toml Outdated
Comment thread cot/src/db/fields/chrono_wrapper.rs Outdated
Comment thread cot/src/db/fields/chrono_wrapper.rs
@seqre seqre force-pushed the chrono-support branch from 432b7d7 to b0450d4 Compare June 4, 2025 20:58
@seqre seqre merged commit 1768bc3 into master Jun 4, 2025
32 checks passed
@seqre seqre deleted the chrono-support branch June 4, 2025 22:10
@cotbot cotbot Bot mentioned this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-lib Crate: cot (main library crate)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants