Skip to content

fix!: OpenAPI specs with item references#333

Merged
m4tx merged 5 commits into
masterfrom
openapi-fix
May 25, 2025
Merged

fix!: OpenAPI specs with item references#333
m4tx merged 5 commits into
masterfrom
openapi-fix

Conversation

@m4tx

@m4tx m4tx commented May 16, 2025

Copy link
Copy Markdown
Member

No description provided.

@m4tx m4tx requested a review from seqre May 16, 2025 14:38
@github-actions github-actions Bot added the C-lib Crate: cot (main library crate) label May 16, 2025
@seqre seqre removed their request for review May 16, 2025 18:09
@codecov

codecov Bot commented May 16, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cot/src/openapi/swagger_ui.rs 0.00% 1 Missing ⚠️
Flag Coverage Δ
rust 88.18% <96.15%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cot/src/router.rs 92.89% <100.00%> (+0.32%) ⬆️
cot/src/openapi/swagger_ui.rs 76.92% <0.00%> (+5.49%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@seqre seqre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, but please add tests.

@m4tx m4tx requested a review from seqre May 24, 2025 20:26
@m4tx m4tx merged commit 24156a8 into master May 25, 2025
32 checks passed
@m4tx m4tx deleted the openapi-fix branch May 25, 2025 09:06
@cotbot cotbot Bot mentioned this pull request May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-lib Crate: cot (main library crate)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants