Skip to content

feat!: add support for file fields in forms#334

Merged
m4tx merged 5 commits into
masterfrom
more-form-fields
May 24, 2025
Merged

feat!: add support for file fields in forms#334
m4tx merged 5 commits into
masterfrom
more-form-fields

Conversation

@m4tx

@m4tx m4tx commented May 19, 2025

Copy link
Copy Markdown
Member

No description provided.

@m4tx m4tx requested a review from seqre May 19, 2025 15:43
@github-actions github-actions Bot added C-lib Crate: cot (main library crate) C-macros Crate: cot-macros labels May 19, 2025
@codecov

codecov Bot commented May 19, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 92.53438% with 38 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cot/src/form/field_value.rs 83.14% 15 Missing ⚠️
cot/src/form.rs 92.98% 4 Missing and 8 partials ⚠️
cot/src/form/fields/files.rs 93.15% 8 Missing and 2 partials ⚠️
cot/src/form/fields.rs 98.93% 0 Missing and 1 partial ⚠️
Flag Coverage Δ
rust 88.14% <92.53%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cot-macros/src/admin.rs 89.58% <ø> (ø)
cot-macros/src/form.rs 96.72% <100.00%> (ø)
cot/src/admin.rs 73.42% <100.00%> (-0.25%) ⬇️
cot/src/error.rs 88.05% <ø> (ø)
cot/src/html.rs 97.59% <100.00%> (+0.02%) ⬆️
cot/src/openapi.rs 93.47% <100.00%> (-0.18%) ⬇️
cot/src/request.rs 95.91% <ø> (-0.17%) ⬇️
cot/src/form/fields.rs 87.36% <98.93%> (+0.69%) ⬆️
cot/src/form/fields/files.rs 93.15% <93.15%> (ø)
cot/src/form.rs 92.94% <92.98%> (+5.44%) ⬆️
... and 1 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@m4tx m4tx force-pushed the more-form-fields branch from 4e9fc91 to 4de6e80 Compare May 19, 2025 16:44

@seqre seqre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, I'd like to get answers first before approving though

Comment thread cot/src/admin.rs
Comment thread cot/src/form.rs Outdated
Comment thread cot/src/form.rs
Comment thread cot/src/form/field_value.rs
@m4tx m4tx changed the title feat: add support for file fields in forms feat!: add support for file fields in forms May 19, 2025
@m4tx m4tx requested a review from seqre May 20, 2025 00:11
@m4tx m4tx merged commit d1c6d72 into master May 24, 2025
33 checks passed
@m4tx m4tx deleted the more-form-fields branch May 24, 2025 10:11
@cotbot cotbot Bot mentioned this pull request May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-lib Crate: cot (main library crate) C-macros Crate: cot-macros

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants