Skip to content

feat!: add SelectField; support more chrono form fields#345

Merged
m4tx merged 4 commits into
masterfrom
more-form-fields2
Jun 5, 2025
Merged

feat!: add SelectField; support more chrono form fields#345
m4tx merged 4 commits into
masterfrom
more-form-fields2

Conversation

@m4tx

@m4tx m4tx commented Jun 4, 2025

Copy link
Copy Markdown
Member

No description provided.

@m4tx m4tx requested a review from seqre June 4, 2025 19:53
@github-actions github-actions Bot added C-cli Crate: cot-cli (issues and Pull Requests related to Cot CLI) C-lib Crate: cot (main library crate) C-macros Crate: cot-macros labels Jun 4, 2025
@codecov

codecov Bot commented Jun 4, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 97.18151% with 25 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cot/src/form/fields/select.rs 96.29% 9 Missing and 4 partials ⚠️
cot-macros/src/utils.rs 64.70% 6 Missing ⚠️
cot/src/form/fields/chrono.rs 99.23% 1 Missing and 2 partials ⚠️
cot/src/html.rs 97.41% 3 Missing ⚠️
Flag Coverage Δ
rust 88.73% <97.18%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cot-macros/src/form.rs 96.77% <100.00%> (+0.05%) ⬆️
cot-macros/src/lib.rs 96.29% <ø> (ø)
cot/src/form.rs 91.76% <ø> (-1.18%) ⬇️
cot/src/form/fields.rs 87.67% <100.00%> (ø)
cot/src/form/fields/chrono.rs 99.23% <99.23%> (ø)
cot/src/html.rs 97.44% <97.41%> (-0.15%) ⬇️
cot-macros/src/utils.rs 64.70% <64.70%> (ø)
cot/src/form/fields/select.rs 96.29% <96.29%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@seqre seqre force-pushed the more-form-fields2 branch from 46868de to f29e494 Compare June 4, 2025 22:21

@seqre seqre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful contribution, but I have a few questions before approving.

Comment thread cot/src/form/fields.rs
Comment thread cot/tests/form.rs
Comment thread cot/src/form/fields/select.rs

@seqre seqre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m4tx m4tx enabled auto-merge (squash) June 5, 2025 16:46
@m4tx m4tx merged commit 477728e into master Jun 5, 2025
22 checks passed
@m4tx m4tx deleted the more-form-fields2 branch June 5, 2025 16:53
@cotbot cotbot Bot mentioned this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cli Crate: cot-cli (issues and Pull Requests related to Cot CLI) C-lib Crate: cot (main library crate) C-macros Crate: cot-macros

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants