feat: basic benchmarking#378
Conversation
a890711 to
594c45c
Compare
|
Bencher Report| Branch | basic-benchmarking |
| Testbed | github-ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | Latency | microseconds (µs) |
|---|---|---|
| empty_router/empty_router | 📈 view plot | 5,994.90 µs |
| json_api/json_api | 📈 view plot | 994.68 µs |
| nested_routers/nested_routers | 📈 view plot | 931.57 µs |
| single_root_route/single_root_route | 📈 view plot | 888.36 µs |
| single_root_route_burst/single_root_route_burst | 📈 view plot | 17,363.00 µs |
313fa61 to
840b7c3
Compare
m4tx
left a comment
There was a problem hiding this comment.
Nice work! A few comments from me.
Should we set up some thresholds so that bencher stops complaining about them not being set in the GH comment it creates?
# Conflicts: # Cargo.lock # cot/Cargo.toml
cd39fe1 to
b713847
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
m4tx
left a comment
There was a problem hiding this comment.
As per my last review:
Should we set up some thresholds so that bencher stops complaining about them not being set in the GH comment it creates?
Also, can we add some information about how benches work, their configuration, etc. to CONTRIBUTING.md?
They were already added back then here, but until bencher runs at least once on |
Looking good; just please make sure the benchmarks work as intended in the future PRs! |
m4tx
left a comment
There was a problem hiding this comment.
Good stuff; let's see how it works in practice!
No description provided.