Skip to content

Conversation

@mmetc
Copy link
Contributor

@mmetc mmetc commented Nov 3, 2025

No description provided.

@mmetc mmetc added this to the 1.7.4 milestone Nov 3, 2025
@mmetc mmetc added the kind/enhancement New feature or request label Nov 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.71%. Comparing base (ca9cbe2) to head (6275b0f).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apiserver/apiserver.go 86.36% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4021      +/-   ##
==========================================
+ Coverage   62.66%   62.71%   +0.05%     
==========================================
  Files         416      416              
  Lines       32959    32958       -1     
==========================================
+ Hits        20653    20670      +17     
+ Misses      10183    10170      -13     
+ Partials     2123     2118       -5     
Flag Coverage Δ
bats 46.42% <86.36%> (+0.01%) ⬆️
unit-linux 35.33% <9.09%> (+0.05%) ⬆️
unit-windows 24.70% <9.09%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmetc
Copy link
Contributor Author

mmetc commented Nov 3, 2025

todo in a future PR: store a reference to the lapi config in Controller / V1Controller as well and remove the redundant fields

@mmetc mmetc merged commit a6b61ed into master Nov 7, 2025
21 of 22 checks passed
@mmetc mmetc deleted the apiserver-cfg branch November 7, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request needs/area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants