Repository navigation
Move Share Requirements out from protocols #392
Description
If the requirements must be identical for each protocol via which a share is provided, we should move them out from NewShare.protocol[*].requirements to NewShare.requirements instead of duplicating them.
In my opinion the protocols should only contain information relevant to the individual transport and non-supported protocols should be safe to ignore.
Lines 1137 to 1145 in a5b5da6
Are there any implementations which use the Share Requirements so far? The requirements where only defined for WebDAV in previous versions.
Activity
glpatcern commentedon Aug 17, 2026
The reason why the
requirementswere included in the specificprotocolsis mostly historical: it appeared to be specific towebdav, and whensshwas introduced it did not really apply (though that's questionable). Thenwebappwas refreshed to be on-par in terms of security and it turned out that the samerequirementsforwebdavare to be included inwebapp.Now, the suggestion to bring them to the top does look reasonable. But we should consider that there are multiple implementations already. Let's discuss this at the next meeting in one week.