Skip to content

docs: clarify conditional formatting behavior under column pivots#11323

Open
igorlukanin wants to merge 1 commit into
masterfrom
igor/cub-3058-cf-under-pivot-docs
Open

docs: clarify conditional formatting behavior under column pivots#11323
igorlukanin wants to merge 1 commit into
masterfrom
igor/cub-3058-cf-under-pivot-docs

Conversation

@igorlukanin

Copy link
Copy Markdown
Member

Summary

Documents how conditional-formatting rules behave under a column pivot in the table visualization: a row-spanning rule (Entire row / Selected columns) styles each measure cell by its own pivot combination's value, and leaves cells with no single value to test — row headers, row dimensions, and rules sourced on a dimension pivoted into columns — unstyled.

Adds one short paragraph to the Conditional formatting section of the table chart page.

Test plan

  • Prose only; renders in the Conditional formatting section of explore-analyze/charts/chart-types/table.mdx

@igorlukanin
igorlukanin requested a review from keydunov as a code owner July 21, 2026 23:33
@claude

claude Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 27s —— View job


Review

Docs LGTM — 1 low (readability nit)
  • Read PR diff
  • Review the added prose

Change under reviewdocs-mintlify/docs/explore-analyze/charts/chart-types/table.mdx:276, a single paragraph clarifying conditional-formatting behavior under column pivots.

Assessment: Content is accurate and complements the existing Conditional formatting section. Prose-only, no code impact, no tests needed.

Minor readability nit (non-blocking): the second sentence is long (~50 words) and stacks a parenthetical, a because-clause, and the rule outcome. Splitting after the parenthetical would improve scannability, e.g.:

Under a column pivot, a row spans several values of the same measure — one per pivot combination. A row-spanning rule (Entire row or Selected columns) styles each measure cell by its own combination's value. Cells with no single value to test — row headers, row dimensions, and any rule whose source dimension has been pivoted into columns — are left unstyled.

Also consider hyphenating row-spanning on first use for consistency (already used later in the sentence).

Nothing blocking. Ship it.

• [Branch](https://github.com/cube-js/cube/tree/igor/cub-3058-cf-under-pivot-docs)

@mintlify

mintlify Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
cubed3 🟢 Ready View Preview Jul 21, 2026, 11:33 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@mintlify

mintlify Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
cubed3 🟡 Building Jul 21, 2026, 11:33 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant