Skip to content

fix module context starting before Home Assistant; see #784 - #785

Merged
craigbarratt merged 1 commit into
custom-components:masterfrom
dmamelin:fix-module-start-before-hass
Dec 13, 2025
Merged

craigbarratt merged 1 commit into
custom-components:masterfrom
dmamelin:fix-module-start-before-hass

Conversation

@dmamelin

@dmamelin dmamelin commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

Explanation:
Before this PR, all imported modules were always assigned auto_start = True, which caused their triggers to run immediately after the file was loaded:

load files from disk → import modules → module.set_auto_start(True) → run module triggers (including the factories) →
wait for HA startup → run file-level triggers

After this PR, a module inherits the auto_start value of the current context:
• If Home Assistant is already running, behavior remains unchanged.
• If HA is still starting up, the current context has auto_start == False, and the module receives the same value.
In this case, the module will start later in start_global_context, together with all other contexts.

@ALERTua

ALERTua commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

This PR did not break anything for me, it seems.

@dmamelin

dmamelin commented Dec 9, 2025

Copy link
Copy Markdown
Contributor Author

Perhaps in start_global_context, modules should be launched first so that their triggers and trigger-factories can execute, and then everything else. This would preserve the startup order as before.
But I don't see the point - the order of execution of pyscript triggers isn't guaranteed.

@craigbarratt
craigbarratt merged commit b7b40e0 into custom-components:master Dec 13, 2025
6 checks passed
@craigbarratt

Copy link
Copy Markdown
Member

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants