Repository navigation
Question: About usage of RandomAccessVectorValues in GraphIndexBuilder API #158
Description
GraphIndexBuilder constructor requires a RandomAccessVectorValues reference and in javadoc it's defined as:
the vectors whose relations are represented by the graph - must provide a different view over those vectors than the one used to add via addGraphNode.
In GraphIndexBuilder.addGraphNode() method, second parameter is again a RandomAccessVectorValues reference. Should this RandomAccessVectorValues instance be different from the one passed in constructor?
addGraphNode() call fails if the newly added node doesn't exist in the constructor RandomAccessVectorValues. In the examples, as far as I see, they are always the same instance.
I didn't exactly understand relation between these two RandomAccessVectorValues instances. Can you please add some explanation and/or docs for this?
Activity
jbellis commentedon Nov 28, 2023
You're right, this is a clunky design. In the distant past the RAVV was not provided to the constructor, but now that it is, it can be removed from addGraphNode.
mdogan commentedon Apr 16, 2024
Fixed in #244