wire: Add SerializeSize to Message interface - #3746
Merged
Merged
Conversation
davecgh
reviewed
Jul 23, 2026
davecgh
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. I'll review this over the next couple of days since it's pretty large.
davecgh
reviewed
Jul 24, 2026
davecgh
left a comment
Member
There was a problem hiding this comment.
I'm about 3/4 through this. Will finish reviewing the rest later. A few comments inline for now.
davecgh
reviewed
Jul 24, 2026
davecgh
left a comment
Member
There was a problem hiding this comment.
I finished reviewing everything now. Nothing else to add over the existing comment. Looks good otherwise!
jholdstock
force-pushed
the
serialize-size
branch
from
July 25, 2026 05:53
8ef2dc2 to
6aa2fc4
Compare
Member
Author
|
Implemented your suggestion. Also moved |
jholdstock
force-pushed
the
serialize-size
branch
from
July 25, 2026 06:27
6aa2fc4 to
f13141b
Compare
davecgh
approved these changes
Jul 25, 2026
Member
|
Please rebase this over master and I'll get it merged. |
Add SerializeSize to the Message interface, and add an implementation of SerializeSize to every message which was missing one. Also update the tests of every message so that SerializeSize is exercised at least once.
jholdstock
force-pushed
the
serialize-size
branch
from
July 25, 2026 13:04
f13141b to
fbdf1af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #3744
Add SerializeSize to the Message interface, and add an implementation of SerializeSize to every message which was missing one. Also update the tests of every message so that SerializeSize is exercised at least once.