dexc-desktop: Snap package

[peterzen]

This PR adds configuration, build scripts and Github workflow to build the Snap package and publishing it in the Snap Store.

The snap build uses the .deb package. The PR also contains a few fixes/improvements in the deb build:

• Icons: added SVG icon for hicolor and symbolic variations, fixed 128px PNG to match official version
• icon install location changed to /usr/share/icons which is the XDG standard
• binary installs in /usr/bin directly (this is standard practice, simplifies deb scripts)
• added AppStream metainfo file (for GNOME/KDE/Ubuntu software centers and the snap)

[JoeGruffins]

Getting an error when running ./pkg/pkg-debian.sh:

dpkg-deb: error: parsing file './build/dexc_bf46fe348fb83893408e875408499761a3df5ea4-0_amd64/DEBIAN/control' near line 2 package 'dexc':
 'Version' field value 'bf46fe348fb83893408e875408499761a3df5ea4': version number does not start with digit

[peterzen]

dpkg-deb: error: parsing file './build/dexc_bf46fe348fb83893408e875408499761a3df5ea4-0_amd64/DEBIAN/control' near line 2 package 'dexc':
'Version' field value 'bf46fe348fb83893408e875408499761a3df5ea4': version number does not start with digit

It pulls the version number from the git tag - the idea being that for release builds there's always a tag but for dev builds the commit hash confuses the deb build. Maybe this needs to be reconsidered.

If you git tag v0.7.0 or similar it will work.

[JoeGruffins]

It pulls the version number from the git tag - the idea being that for release builds there's always a tag but for dev builds the commit hash confuses the deb build. Maybe this needs to be reconsidered.

So the commit needs a tag to work? I did not know. Maybe add that to the readme there at least if it is a requirement?

[JoeGruffins]

After adding a bogus tag was able to build and install with snap.

[buck54321]

I'm not seeing the benefit of the github actions deployment. What does it do for us over just running the script ourselves?

Icons: added SVG icon for hicolor and symbolic variations, fixed 128px PNG to match official version

Can you say more about the new files and what they do for us? Or point me to some documentation?

I don't care about the official logo version. I changed it because the official color was too dark and looked bad in my panel. None of this matters much, of course, because we're rebranding anyway, but prefer to use the lighter color that has margins.

[peterzen]

I'm not seeing the benefit of the github actions deployment. What does it do for us over just running the script ourselves?

It does the same thing but makes life a tad easier. snapcraft, the snap builder isn't straightforward to run on systems other than Ubuntu as it requires several manual steps to initialize lxd which the build relies on. So basically you need to run the script in an Ubuntu VM which I presumed isn't the system of choice for running release builds.

The binary it packages into a snap comes from the .deb package.

Icons: added SVG icon for hicolor and symbolic variations, fixed 128px PNG to match official version

Can you say more about the new files and what they do for us? Or point me to some documentation?

dexc.png is scaled to 128px which is one of the default icon sizes, the 100px version was scaled up and rendered blurry
dexc.svg is a scalable version which the desktop environment picks up when a bitmap in the required size is not available
dexc-symbolic.svg is a B/W version that the desktop environment might use with certain accessibility settings like monochrome etc. Also this is ideally the icon to be used in the systray as in that size this provides the most contrast.

https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html

I don't care about the official logo version. I changed it because the official color was too dark and looked bad in my panel. None of this matters much, of course, because we're rebranding anyway, but prefer to use the lighter color that has margins.

The tray icon should really match the other icons (menu, dock, task switcher), if it's different it looks odd. How about using the monochrome version? That's the most distinctly recognizable in the tray visually.

[JoeGruffins]

The icon client/cmd/bisonw-desktop/src/bisonw.svg looks outdated. Should be one of these top two maybe? https://github.com/decred/dcrdex/tree/master/docs/branding

[JoeGruffins]

Trying to build on a clean ubuntu 24.04 but stuck at these dependencies.

E: Unable to locate package libwebkit2gtk-4.0-dev
E: Couldn't find any package by glob 'libwebkit2gtk-4.0-dev'
E: Couldn't find any package by regex 'libwebkit2gtk-4.0-dev'

[JoeGruffins]

on Ubuntu 24.04 I had to do the things labeled Debian

[peterzen]

Yeah some things have changed since this was written 2 years ago... I wonder if it's worth warming up this PR at all, considering it wasn't merged for so long.

[peterzen]

E: Unable to locate package libwebkit2gtk-4.0-dev
E: Couldn't find any package by glob 'libwebkit2gtk-4.0-dev'
E: Couldn't find any package by regex 'libwebkit2gtk-4.0-dev'

Apparently, libwebkit2gtk-4.0 was dropped from Ubuntu as of 24.0, but github.com/webview/webview has not been updated to link against 4.1 - this breaks the build (not just the snap package). There's an open PR fixing this (https://github.com/webview/webview_go/pull/62/files) but it hasn't been merged for quite some time (webview_go seems to be unmaintained).

We have 2 options - wait for that above PR to be merged, or fork webview_go, fix the deps and use that going forward. I think option 2 is the way to go.

cc @buck54321

[JoeGruffins]

I guess this should be good to go after rebase?

[peterzen]

I guess this should be good to go after rebase?

Yes, rebase is done and the README updated as well.

[JoeGruffins]

@peterzen sorry, I merged your other pr first and it created a conflict

[JoeGruffins]

I was able to build on newest Ubuntu.