app: Fix market page form close - #3053
Merged
Merged
Conversation
JoeGruffins
approved these changes
Nov 2, 2024
buck54321
reviewed
Nov 7, 2024
Comment on lines
424
to
429
| bind(page.forms, 'mousedown', (e: MouseEvent) => { | ||
| if (Doc.isDisplayed(page.vDetailPane) && !Doc.mouseInElement(e, page.vDetailPane)) return this.showVerifyForm() | ||
| if (!Doc.mouseInElement(e, this.currentForm)) { | ||
| if (this.forms.currentForm && !Doc.mouseInElement(e, this.forms.currentForm)) { | ||
| closePopups() | ||
| } | ||
| }) |
Member
There was a problem hiding this comment.
Hmm. Why is this even here? Doesn't the Forms class take care of this?
martonp
force-pushed
the
fixMarketPageFormClose
branch
from
November 8, 2024 04:24
692651e to
343815b
Compare
Fixes a bug related to closing popups on the market page.
martonp
force-pushed
the
fixMarketPageFormClose
branch
from
November 8, 2024 04:39
343815b to
b138e04
Compare
buck54321
pushed a commit
to buck54321/dcrdex
that referenced
this pull request
Nov 12, 2024
Fixes a bug related to closing popups on the market page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug related to closing popups on the market page.