mm/binance: Use filters and withdraw multiple - #3093
Merged
Conversation
martonp
force-pushed
the
priceFilters
branch
from
November 22, 2024 12:04
06a8b19 to
47d2deb
Compare
buck54321
requested changes
Nov 28, 2024
buck54321
left a comment
Member
There was a problem hiding this comment.
I think this can be much simpler. Please review these two suggestions.
martonp
marked this pull request as ready for review
November 28, 2024 10:21
dev-warrior777
approved these changes
Nov 28, 2024
| req.Header = header | ||
|
|
||
| return req, nil | ||
| // bnc.log.Tracef("Sending request: %+v", req) |
Contributor
There was a problem hiding this comment.
Do you still need this?
Member
|
Needs a rebase, but look great. |
buck54321
reviewed
Nov 29, 2024
| conv := float64(qui.Conventional.ConversionFactor) / float64(bui.Conventional.ConversionFactor) * calc.RateEncodingFactor | ||
| market.RateStep = uint64(math.Round(filter.TickSize * conv)) | ||
| market.MinPrice = uint64(math.Round(filter.MinPrice * conv)) | ||
| market.MaxPrice = uint64(math.Round(filter.MaxPrice * conv)) // Why was the conv outside of the math.Round? |
Member
There was a problem hiding this comment.
// Why was the conv outside of the math.Round?
Not sure. Whadya expect me to test my code suggestions? 🤪
Collaborator
Author
There was a problem hiding this comment.
Lol that comment was kind of meant for myself.
The price and lot size filters were not being used, leading to trade errors. The withdraw multiple was also not being used leading to withdraw errors.
martonp
force-pushed
the
priceFilters
branch
from
November 29, 2024 09:39
abde4ea to
3db198f
Compare
JoeGruffins
approved these changes
Nov 29, 2024
martonp
added a commit
to martonp/dcrdex
that referenced
this pull request
Feb 6, 2025
* mm/binance: Use filters and withdraw multiple The price and lot size filters were not being used, leading to trade errors. The withdraw multiple was also not being used leading to withdraw errors.
buck54321
pushed a commit
to buck54321/dcrdex
that referenced
this pull request
Feb 25, 2025
* mm/binance: Use filters and withdraw multiple The price and lot size filters were not being used, leading to trade errors. The withdraw multiple was also not being used leading to withdraw errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The price and lot size filters were not being used, leading to trade
errors. The withdraw multiple was also not being used leading to withdraw
errors.