client/dcr: Create new syncer on Run error. - #3215
Merged
Merged
Conversation
martonp
reviewed
Mar 25, 2025
Comment on lines
+427
to
+431
| syncer, err := w.newSpvSyncer() | ||
| if err != nil { | ||
| w.log.Errorf("unable to create spv syncer: %v", err) | ||
| return | ||
| } |
Collaborator
There was a problem hiding this comment.
If newSpvSyncer returns an error, this loop will never restart, startWallet will return without error, and the wallet will remain connected. newSpvSyncer doesn't need to return an error though. The only case it returns an error is if dcrWallet is not an extendedWallet, and that can just be a panic.
Member
Author
There was a problem hiding this comment.
Why are we using an interface there, for testing?
JoeGruffins
force-pushed
the
fixsyncpanic
branch
from
March 26, 2025 06:17
7e72ad2 to
6be67f3
Compare
buck54321
approved these changes
Apr 1, 2025
martonp
pushed a commit
to martonp/dcrdex
that referenced
this pull request
May 7, 2025
martonp
pushed a commit
to martonp/dcrdex
that referenced
this pull request
Jul 8, 2025
buck54321
pushed a commit
that referenced
this pull request
Jul 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3208