electrum: Fix GetBlockHash for Firo compatibility#3251
Merged
Conversation
Fixed GetBlockHash to handle Firo's 120-byte block header. Previously, it deserialized a hex string and re-serialized it in Bitcoin's 80-byte format before double SHA-256 hashing, causing issues with Firo. Now, the hex string is converted to bytes and hashed.
JoeGruffins
approved these changes
Apr 21, 2025
JoeGruffins
left a comment
Member
There was a problem hiding this comment.
Not tested but change looks good.
Member
|
Does this fix #3252 or is that something different? |
Collaborator
Author
No, it's something different. |
Member
|
Ok, just waiting for @dev-warrior777 review. |
dev-warrior777
approved these changes
Apr 23, 2025
martonp
added a commit
to martonp/dcrdex
that referenced
this pull request
May 7, 2025
Fixed GetBlockHash to handle Firo's 120-byte block header. Previously, it deserialized a hex string and re-serialized it in Bitcoin's 80-byte format before double SHA-256 hashing, causing issues with Firo. Now, the hex string is converted to bytes and hashed.
martonp
added a commit
to martonp/dcrdex
that referenced
this pull request
Jul 8, 2025
Fixed GetBlockHash to handle Firo's 120-byte block header. Previously, it deserialized a hex string and re-serialized it in Bitcoin's 80-byte format before double SHA-256 hashing, causing issues with Firo. Now, the hex string is converted to bytes and hashed.
buck54321
pushed a commit
that referenced
this pull request
Jul 26, 2025
Fixed GetBlockHash to handle Firo's 120-byte block header. Previously, it deserialized a hex string and re-serialized it in Bitcoin's 80-byte format before double SHA-256 hashing, causing issues with Firo. Now, the hex string is converted to bytes and hashed.
JoeGruffins
pushed a commit
to JoeGruffins/dcrdex
that referenced
this pull request
Oct 7, 2025
Fixed GetBlockHash to handle Firo's 120-byte block header. Previously, it deserialized a hex string and re-serialized it in Bitcoin's 80-byte format before double SHA-256 hashing, causing issues with Firo. Now, the hex string is converted to bytes and hashed.
JoeGruffins
pushed a commit
to JoeGruffins/dcrdex
that referenced
this pull request
Oct 13, 2025
Fixed GetBlockHash to handle Firo's 120-byte block header. Previously, it deserialized a hex string and re-serialized it in Bitcoin's 80-byte format before double SHA-256 hashing, causing issues with Firo. Now, the hex string is converted to bytes and hashed.
buck54321
pushed a commit
that referenced
this pull request
Oct 17, 2025
Fixed GetBlockHash to handle Firo's 120-byte block header. Previously, it deserialized a hex string and re-serialized it in Bitcoin's 80-byte format before double SHA-256 hashing, causing issues with Firo. Now, the hex string is converted to bytes and hashed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed GetBlockHash to handle Firo's 120-byte block header. Previously, it deserialized a hex string and re-serialized it in Bitcoin's 80-byte format before double SHA-256 hashing, causing issues with Firo. Now, the hex string is converted to bytes and hashed.