libxc: VWAP overflow fix - #3299
Merged
Merged
Conversation
The VWAP calculation was multiplying uint64 rates and quantities to keep track of a weighted total. This could result in a uint64 overflow. The calculation is updated to use `big.Int` instead.
JoeGruffins
approved these changes
Jun 26, 2025
martonp
added a commit
to martonp/dcrdex
that referenced
this pull request
Jul 8, 2025
The VWAP calculation was multiplying uint64 rates and quantities to keep track of a weighted total. This could result in a uint64 overflow. The calculation is updated to use `big.Int` instead.
buck54321
pushed a commit
that referenced
this pull request
Jul 26, 2025
The VWAP calculation was multiplying uint64 rates and quantities to keep track of a weighted total. This could result in a uint64 overflow. The calculation is updated to use `big.Int` instead.
JoeGruffins
pushed a commit
to JoeGruffins/dcrdex
that referenced
this pull request
Oct 7, 2025
The VWAP calculation was multiplying uint64 rates and quantities to keep track of a weighted total. This could result in a uint64 overflow. The calculation is updated to use `big.Int` instead.
JoeGruffins
pushed a commit
to JoeGruffins/dcrdex
that referenced
this pull request
Oct 13, 2025
The VWAP calculation was multiplying uint64 rates and quantities to keep track of a weighted total. This could result in a uint64 overflow. The calculation is updated to use `big.Int` instead.
buck54321
pushed a commit
that referenced
this pull request
Oct 17, 2025
The VWAP calculation was multiplying uint64 rates and quantities to keep track of a weighted total. This could result in a uint64 overflow. The calculation is updated to use `big.Int` instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VWAP calculation was multiplying uint64 rates and quantities to keep track of a weighted total. This could result in a uint64 overflow. The calculation is updated to use
big.Intinstead.