bisonw-darwin: Fix seg fault on window close - #3366
Merged
Merged
Conversation
JoeGruffins
approved these changes
Oct 9, 2025
JoeGruffins
left a comment
Member
There was a problem hiding this comment.
Working well for me.
While you are here can you do a couple things? The install script isn't watching arguments like it should. If I build with TARGETS=darwin/arm64 ./pkg-darwin.sh it should only build the arm binary but it builds both. I had made a change for this locally before but I've lost it, it's a small change.
Also can you add a note in the README the go version used must be 1.24.8 or lower atm and the reason why?
Also, the README says you can do ./pkg/pkg-darwin.sh but you can't because you have to be in the ./pkg dir because it does some ../ thing
martonp
marked this pull request as ready for review
October 10, 2025 15:04
dev-warrior777
approved these changes
Oct 11, 2025
Member
|
@martonp Do you want to put something in the readme about the mac go version? |
Member
|
This still doesn't seem to work from the parent directory: |
Fixes a segmentation fault that occurs when web views are destroyed. Apperantly some memory is corrupted causing the seg fault. Web views are no longer destroyed, just hidden and reopened.
martonp
added a commit
to martonp/dcrdex
that referenced
this pull request
Oct 15, 2025
Fixes a segmentation fault that occurs when web views are destroyed. Apperantly some memory is corrupted causing the seg fault. Web views are no longer destroyed, just hidden and reopened.
buck54321
pushed a commit
that referenced
this pull request
Oct 17, 2025
Fixes a segmentation fault that occurs when web views are destroyed. Apperantly some memory is corrupted causing the seg fault. Web views are no longer destroyed, just hidden and reopened.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a segmentation fault that occurs when web views are destroyed. Apperantly some memory is corrupted causing the seg fault. Web views are no longer destroyed, just hidden and reopened.