Skip to content

Building in Kaniko is broken from Windows in devspace 6+#2423

Merged
FabianKramm merged 3 commits into
devspace-sh:mainfrom
lizardruss:fix-kaniko-windows
Nov 15, 2022
Merged

Building in Kaniko is broken from Windows in devspace 6+#2423
FabianKramm merged 3 commits into
devspace-sh:mainfrom
lizardruss:fix-kaniko-windows

Conversation

@lizardruss

@lizardruss lizardruss commented Nov 15, 2022

Copy link
Copy Markdown
Collaborator

What issue type does this pull request address?
/kind bugfix

What does this pull request do? Which issues does it resolve?
resolves #2412
fixes ENG-606

Please provide a short message that should be published in the DevSpace release notes
Fixed issues where DevSpace would:

  • force local registry with kaniko builds, even if --no-push is used
  • use the wrong path delimiters in windows
  • fail to skip local registry for loft vclusters on local kubernetes

@lizardruss lizardruss changed the title wip: refactor for kaniko builds Building in Kaniko is broken from Windows in devspace 6+ Nov 15, 2022
@lizardruss lizardruss marked this pull request as ready for review November 15, 2022 08:12

@FabianKramm FabianKramm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizardruss thanks for the PR! LGTM!

@FabianKramm FabianKramm merged commit 4be3908 into devspace-sh:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Building in Kaniko is broken from Windows in devspace 6+

2 participants