Skip to content

fix: Prevent constant rebuilding with local registry #2444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lizardruss merged 1 commit into from
Nov 29, 2022
Merged

fix: Prevent constant rebuilding with local registry #2444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/devspace/build/builder/buildkit/buildkit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func (b *Builder) Build(ctx devspacecontext.Context) error {
func (b *Builder) ShouldRebuild(ctx devspacecontext.Context, forceRebuild bool) (bool, error) {
// Check if image is present in local registry
imageCache, _ := ctx.Config().LocalCache().GetImageCache(b.helper.ImageConfigName)
imageName := imageCache.ResolveImage()
imageName := imageCache.ResolveImage() + ":" + imageCache.Tag

if imageCache.IsLocalRegistryImage() {
found, err := registry.IsImageAvailableRemotely(ctx.Context(), imageName)
Expand Down
2 changes: 1 addition & 1 deletion pkg/devspace/build/builder/docker/docker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func (b *Builder) Build(ctx devspacecontext.Context) error {
func (b *Builder) ShouldRebuild(ctx devspacecontext.Context, forceRebuild bool) (bool, error) {
// Check if image is present in local registry
imageCache, _ := ctx.Config().LocalCache().GetImageCache(b.helper.ImageConfigName)
imageName := imageCache.ResolveImage()
imageName := imageCache.ResolveImage() + ":" + imageCache.Tag

if imageCache.IsLocalRegistryImage() {
found, err := registry.IsImageAvailableRemotely(ctx.Context(), imageName)
Expand Down