Skip to content

Pin mypy for regression in v1.12.#484

Merged
andrewgodwin merged 1 commit into
mainfrom
pin-mypy
Dec 8, 2024
Merged

Pin mypy for regression in v1.12.#484
andrewgodwin merged 1 commit into
mainfrom
pin-mypy

Conversation

@carltongibson

Copy link
Copy Markdown
Member

See issue: python/mypy#17960
Fixed in master: python/mypy#17355 after last release v1.3.0.

Checks have been failing since mypy 1.12 release:

asgiref/sync.py:291: error: Too few arguments for "__call__" of "AsyncToSync"  [call-arg]
asgiref/sync.py:466: error: Too few arguments for "__call__" of "SyncToAsync"  [call-arg]

See issue: python/mypy#17960
Fixed in master: python/mypy#17355 after last release v1.3.0.
Comment thread setup.cfg
Comment on lines +42 to +44
# Pending release of https://github.com/python/mypy/pull/17355
# Likely in v1.13.1+, when pip can be removed.
mypy~=1.11.0

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks pass against mypy's master branch with:

Suggested change
# Pending release of https://github.com/python/mypy/pull/17355
# Likely in v1.13.1+, when pip can be removed.
mypy~=1.11.0
mypy @ git+https://github.com/python/mypy.git@master

@andrewgodwin
andrewgodwin merged commit abc69a0 into main Dec 8, 2024
@andrewgodwin

Copy link
Copy Markdown
Member

Thanks, Carlton!

@andrewgodwin
andrewgodwin deleted the pin-mypy branch December 8, 2024 20:49
@carltongibson carltongibson mentioned this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants