Skip to content

Don't run bundle update in the Dockerfile #3770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdlinville merged 1 commit into from
Jul 3, 2017
Merged

Don't run bundle update in the Dockerfile #3770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
FROM starefossen/github-pages:137

COPY . /usr/src/app/
COPY . /usr/src/app

@thaJeztah thaJeztah Jul 1, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this back, as it doesn't seem related to this change

@mdlinville mdlinville Jul 3, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is related. One is what @johndmulhausen told me to use and the other one (without the /) is what is in the onbuild version of the github-pages plugin. Probably it doesn't matter but I thought maybe it was best to stick to how they had it.


CMD jekyll serve -H 0.0.0.0
CMD bundle exec jekyll serve -d /_site --watch -H 0.0.0.0 -P 4000