remove the dolt archive command - #11217
Merged
Merged
Conversation
The standalone 'dolt archive' command is obsolete; archives are now produced by garbage collection via 'dolt gc --archive-level'. Remove the command and the storage-layer build/revert entry points it was the sole caller of. - Delete commands/archive.go and its two registrations. - Remove nbs.BuildArchive/UnArchive and the private chain they exclusively reached (archiveSingleBlockStore, convertTableFileToArchive, writeDataToArchive, gatherAllChunks, verifyAllChunks, etc.). - Keep the chunk-grouping machinery (ChunkRelations, chunkGroup) for future --archive-level 2 support, along with buildDictionary and indexFinalizeFlushArchive which remain in use. - Drop the command-specific bats tests; migrate tests that used the command only as setup to 'dolt gc --archive-level'. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
@macneale4 DOLT
|
Contributor
|
@macneale4 DOLT
|
Contributor
|
@macneale4 DOLT
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dolt archivecommand was a precursor to GC support using archives. It offered the ability to test and roll back is problems arose. Now that archives are the default and have been for awhile, this command seems unnecessary.