Skip to content

go: sqle: Cleanup comments and function names in DatabaseProvider around creatingDatabases. - #11283

Merged
reltuk merged 1 commit into
mainfrom
aaron/sqle-self-clone-cleanup
Jul 9, 2026
Merged

go: sqle: Cleanup comments and function names in DatabaseProvider around creatingDatabases.#11283
reltuk merged 1 commit into
mainfrom
aaron/sqle-self-clone-cleanup

Conversation

@reltuk

@reltuk reltuk commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Restructure the regression test to be a go-sql-server-driver test and to run a self-clone.

…und creatingDatabases.

Restructure the regression test to be a go-sql-server-driver test and
to run a self-clone.
@reltuk
reltuk requested a review from elianddb July 9, 2026 23:27
@coffeegoddd

Copy link
Copy Markdown
Contributor

@reltuk DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 2.3 2.3 0.0
groupby_scan 144.97 144.97 0.0
index_join 1.96 1.96 0.0
index_join_scan 1.34 1.34 0.0
index_scan 223.34 219.36 -1.78
oltp_point_select 0.26 0.26 0.0
oltp_read_only 5.18 5.18 0.0
select_random_points 0.52 0.51 -1.92
select_random_ranges 0.65 0.65 0.0
table_scan 204.11 207.82 1.82
types_table_scan 475.79 475.79 0.0
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.21 6.21 0.0
oltp_insert 3.13 3.13 0.0
oltp_read_write 11.45 11.45 0.0
oltp_update_index 3.3 3.3 0.0
oltp_update_non_index 3.02 3.02 0.0
oltp_write_only 6.32 6.32 0.0
types_delete_insert 6.79 6.79 0.0

@elianddb elianddb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@coffeegoddd

Copy link
Copy Markdown
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
68aab6d ok 5937471
version total_tests
68aab6d 5937471
correctness_percentage
100.0

@coffeegoddd

Copy link
Copy Markdown
Contributor

@reltuk DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 46.63 45.79 -1.8
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt 0dd48c9 52.58 dolt 68aab6d 52.82 0.46

@reltuk
reltuk merged commit c6a7ab6 into main Jul 9, 2026
40 of 43 checks passed
@github-actions

Copy link
Copy Markdown

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 0.61
adds_updates_deletes 60000 60000 60000 3.04
deletes_only 0 60000 0 1.48
updates_only 0 0 60000 1.77

@github-actions

Copy link
Copy Markdown

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.04 2.25
batching batch sql 10000 1 0.06 2
batching by line sql 10000 1 0.06 2
blob 1 blob 200000 1 0.84 2.87 2.75
blob 2 blobs 200000 1 0.85 2.8 2.75
blob no blob 200000 1 0.82 2.95 2.82
col type datetime 200000 1 0.75 2.84 2.89
col type varchar 200000 1 0.62 4.1 3.79
config width 2 cols 200000 1 0.77 2.66 2.43
config width 32 cols 200000 1 1.71 3.3 2.83
config width 8 cols 200000 1 0.94 2.83 2.6
pk type float 200000 1 0.81 2.68 2.42
pk type int 200000 1 0.73 3.19 2.56
pk type varchar 200000 1 1.35 1.86 1.82
row count 1.6mm 1600000 1 5.33 3.16 2.89
row count 400k 400000 1 1.34 3.13 2.84
row count 800k 800000 1 2.66 3.15 2.9
secondary index four index 200000 1 3.4 1.36 1.09
secondary index no secondary 200000 1 0.8 3 2.89
secondary index one index 200000 1 1.05 2.71 2.36
secondary index two index 200000 1 1.83 1.87 1.77
sorting shuffled 1mm 1000000 0 4.94 2.99 2.65
sorting sorted 1mm 1000000 1 4.98 2.94 2.63

@github-actions

Copy link
Copy Markdown

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.23
dolt_blame_commit_filter system table 1.15
dolt_commit_ancestors_commit_filter system table 0.68
dolt_commits_commit_filter system table 1.11
dolt_diff_log_join_from_commit system table 3.16
dolt_diff_log_join_to_commit system table 3.19
dolt_diff_table_from_commit_filter system table 1.22
dolt_diff_table_to_commit_filter system table 1.22
dolt_diffs_commit_filter system table 1.07
dolt_history_commit_filter system table 1.48
dolt_log_commit_filter system table 1.26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants