Skip to content

LEGO: Pull request from lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20261119183708998 to main - #27405

Open
csigs wants to merge 2 commits into
mainfrom
lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20261119183708998
Open

csigs wants to merge 2 commits into
mainfrom
lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20261119183708998

Conversation

@csigs

@csigs csigs commented Nov 19, 2026

Copy link
Copy Markdown
Member

LEGO: Pull request from lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20261119183708998 to main with localized lcls

Copilot AI balanced review requested due to automatic review settings November 19, 2026 18:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the localization-resource updates.

No open issues 🎉

What changed in this PR

Adds localized MSBuild diagnostic E7201 for .NET for Apple platforms, explaining that --aot is unsupported because Mono AOT compilation has been removed.

Changes:

  • Adds Traditional Chinese, Russian, French, and German translations.
  • Updates localization resources only; no runtime or build logic changes.
File Description
macios/​Localize/​loc/​zh-Hant/​macios/​msbuild/​Xamarin.Localization.MSBuild/​MSBStrings.resx.lcl Adds Traditional Chinese translation of E7201.
macios/​Localize/​loc/​ru/​macios/​msbuild/​Xamarin.Localization.MSBuild/​MSBStrings.resx.lcl Adds Russian translation of E7201.
macios/​Localize/​loc/​fr/​macios/​msbuild/​Xamarin.Localization.MSBuild/​MSBStrings.resx.lcl Adds French translation of E7201.
macios/​Localize/​loc/​de/​macios/​msbuild/​Xamarin.Localization.MSBuild/​MSBStrings.resx.lcl Adds German translation of E7201.

Review effort: Balanced

@rolfbjarne
rolfbjarne enabled auto-merge (squash) November 20, 2026 10:41
@rolfbjarne rolfbjarne added the ready-to-review This PR is ready to review/merge. label Nov 20, 2026
Copilot AI balanced review requested due to automatic review settings November 20, 2026 16:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the E7201 localization updates.

No open issues 🎉

Review effort: Balanced

@MauiBot

MauiBot commented Nov 20, 2026

Copy link
Copy Markdown

🔥 [CI Build #16b70c1] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 4 tests failed, 193 tests passed.

Failures

❌ introspection tests

1 tests failed, 3 tests passed.

Failed tests

  • introspection/macOS/Debug: Failed (Test run crashed (exit code: 134).
    Tests run: 34 Passed: 34 Inconclusive: 0 Failed: 0 Ignored: 0)

Html Report (VSDrops) Download

❌ linker tests (iOS)

1 tests failed, 16 tests passed.

Failed tests

  • dont link/iOS - simulator/Release (CoreCLR, Managed Static Registrar): LaunchTimedOut

Html Report (VSDrops) Download

❌ monotouch tests (iOS)

1 tests failed, 18 tests passed.

Failed tests

  • monotouch-test/iOS - simulator/Release (trimmable static registrar, all optimizations): TimedOut

Html Report (VSDrops) Download

❌ Tests on macOS Golden Gate (27) tests

1 tests failed, 4 tests passed.

Failed tests

  • macOS/osx-arm64 introspection: Failed (exit code 134)
    • No test failure details available. Output tail:
      • 38 libcoreclr.dylib 0x0000000105add278 _ZN8Assembly17ExecuteMainMethodEPP8PtrArrayb + 320
      • 39 libcoreclr.dylib 0x0000000105affd30 _ZN8CorHost215ExecuteAssemblyEjPKDsiPS1_Pj + 748
      • 40 libcoreclr.dylib 0x0000000105cac628 coreclr_execute_assembly + 244
      • 41 introspection 0x00000001044c2e90 mono_jit_exec + 196
      • 42 introspection 0x00000001044c7ae0 xamarin_main + 932
      • 43 introspection 0x00000001044c9244 main + 64
      • 44 dyld 0x000000019af44d7c start + 6652
      • )
      • libc++abi: terminating due to uncaught exception of type NSException
      • Execution completed with exit code 134

Html Report (VSDrops) Download

Successes

✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 17 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 17 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 17 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 19 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 19 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 19 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: 16b70c1bc22fe2b4d153386f3242c99bdafa7319 [PR build]

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-review This PR is ready to review/merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants