Repository navigation
[msbuild] Add remoting support. - #27406
Draft
rolfbjarne wants to merge 35 commits into
Draft
rolfbjarne wants to merge 35 commits into
rolfbjarne wants to merge 35 commits into
Conversation
…tests. The Mac reservation job now copies the built packages into a feed in ~/remote_build_testing/nuget and writes a NuGet.config that uses it. The config's path is passed to the Windows test job as MAC_AGENT_REMOTE_NUGET_CONFIG_FILE, so that ConfigureMac can install workloads on the Mac through RemoteNuGetConfigFile without depending on the Mac's checkout. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…me is /Users/<user>. scp and ssh resolve relative paths against the remote user's home directory, so use relative paths for files in ~/remote_build_testing, and use MAC_AGENT_USER instead of a hard-coded 'builder' when verifying the ssh connection. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The Windows test job no longer needs the Mac checkout to collect logs. Instead, the Mac cleanup job connects to the reserved Mac over SSH after the Windows tests finish, collects the logs, and publishes them as a separate 'windows-remote-logs-*' artifact before returning the Mac to the pool. The zip is no longer included in the Windows HtmlReport. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Require the password-file bridge for remote tests and fail closed for older checkouts that do not have it. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Expose the version chosen by GenerateBuildSessionId so remote setup can install the matching agents. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Escape Azure logging-command characters when publishing the Mac-local NuGet config path. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Stage the private configuration task in both iOS SDKs and expose its remote SDK path to later builds. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use the iOS ConfigureMac target before remote tests and pass its SDK path to subsequent builds. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Restore Xamarin.Messaging.Remote 1.0.4-release-test-remote-macios.26567.2 from the general-testing feed. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add 'make -C msbuild use-local-messaging-remote MESSAGING_REMOTE_PACKAGE=<nupkg>'. It checks the package id, version and task assemblies, restores the Windows task project from the package's directory with a version override, verifies NuGet used that exact package, and refreshes the ConfigureMac files in the installed iOS and Windows SDKs. Tracked feed and version settings don't change. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Reject versions that do not map to a safe normalized cache directory, and avoid deleting the supplied package when it is already in that cache. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Pack the selected devtools checkout during normal builds and consume the exact package path it reports. Reuse local package validation, refresh the installed SDK assets, and restore the tracked version after the override is unset. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Do not pass the macios NuGetPackageRoot environment property into the devtools pack command. Its netstandard build otherwise looks for reference assemblies in a different cache than restore uses. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Reuse the remote-test NuGet config script with configurable source, feed, and config paths. Point install-remote-locally at the built packages and pass the resulting config to ConfigureMac. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
ConfigureMac reads the NuGet config and feed over SSH. macOS doesn't let SSH sessions read external volumes, so when the checkout is on one, copying the config failed with RMAC1050 ('Operation not permitted'). Put the feed in ~/Library/Caches/macios-remote-feed instead (configurable with REMOTE_LOCAL_FEED_DIR).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
SSH access to external volumes can be restricted, but the exact policy depends on the system. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: