Partner referrals#3858
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedToo many files! This PR contains 159 files, which is 9 over the limit of 150. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (159)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR refactors partner country handling, identity verification, and profile management. Country changes move to a new admin API; identity verification now gates on ChangesPartner country management and identity verification refactoring
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests (beta)
|
- Added validation for referral rewards in `validate-reward.ts`, ensuring proper handling of modifiers and configuration. - Updated `referralRewardConfigSchema` to use `commissionsThresholdInCents` instead of `thresholdInCents`. - Enhanced `PartnerReferralRewardBuilder` to accommodate new configuration structure and validation logic. - Adjusted UI components to reflect changes in referral reward configuration handling.
…reward-description.ts`
|
@coderabbitai final review, any breaking changes, security issues, inefficient code? |
|
🔴 Breaking Changes1.
|
| Category | Count | Severity |
|---|---|---|
| Breaking Changes | 4 | Medium–High |
| Security Issues | 3 | Medium–High |
| Inefficient Code | 5 | Low–Medium |
The most urgent items before merge are: (1) the silent catch {} in markApplicationEventSubmittedNetwork, (2) auditing the isFirstCommission optional change for suppressed emails, and (3) the destructive Stripe delete in the admin PATCH endpoint.
✅ Actions performed
Full review triggered.
|
@coderabbitai review my latest changes |
|
✅ Actions performedFull review triggered. |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
|
@coderabbitai full review, any breaking changes? |
|
🔴 Breaking Changes
🔒 Top Security Concern (unchanged)
Triggering a full review now to cover any changes since the last pass. ✅ Actions performedFull review triggered. |
Summary by CodeRabbit
Release Notes
New Features
Improvements