feat: allow headers from openapi#41
Merged
Merged
Conversation
✅ Deploy Preview for df-nextjs-boilerplate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for df-nextjs-boilerplate-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR do?
OpenAPI comes with a key that allows us to identify whether a variable is from the query parameter, body, or header parameter. One particular case that happens a lot is CORS, and if we allow for more secured CORS request, we will eventually have to transform the headers within the request or do some jumps to get it working. This PR enables headers to be generated with other parameters, to allow easy input of header parameters. This is most likely a breaking change, as it alters the arity of the functions generated from Orval.
An example parameter that uses
"in": "header"to allow orval to generate header params: